From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Yann Dirson <ydirson@altern.org>,
git@vger.kernel.org, Yann Dirson <ydirson@free.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v8 1/5] Introduce bulk-move detection in diffcore.
Date: Thu, 25 Nov 2010 09:02:18 -0600 [thread overview]
Message-ID: <20101125150218.GA16049@burratino> (raw)
In-Reply-To: <AANLkTi=Ekoe+RSrRFj63S___Vsa5kTsDKJVPamFsz0c2@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Fri, Oct 29, 2010 at 00:08, Yann Dirson <ydirson@altern.org> wrote:
>> + slash = memrchr(src, '/', len);
>
> I can't compile pu now on Solaris due to this bit. Are you planning on
> picking up the patch / configure / Makefile detection discussed in the
> "[PATCH] compat: add memrchr()" thread? Just wondering what the
> progress was on that.
BTW, remember that the configure / Makefile detection is only an extra
nicety. [1] teaches git to rely on the system memrchr on glibc
systems only; on other systems (unless they define memrchr as a macro,
which would be a strange thing to do), gitmemrchr is used.
Upshot: it should be safe to use [1] without the configure / Makefile
support. Later, an interested person can write a patch for improved
memrchr[2] on *BSD and Plan 9.
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/159081/focus=159121
[2] Lower code size. Maybe faster.
next prev parent reply other threads:[~2010-11-25 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 22:08 [PATCH v8] Detection of directory renames Yann Dirson
2010-10-28 22:08 ` [PATCH v8 1/5] Introduce bulk-move detection in diffcore Yann Dirson
2010-10-29 1:45 ` Jonathan Nieder
2010-10-29 21:18 ` Yann Dirson
2010-10-30 0:26 ` Jonathan Nieder
2010-11-04 21:56 ` Yann Dirson
2010-11-04 21:59 ` [PATCH] " Yann Dirson
2010-11-25 10:08 ` [PATCH v8 1/5] " Ævar Arnfjörð Bjarmason
2010-11-25 15:02 ` Jonathan Nieder [this message]
2010-11-25 17:19 ` Ævar Arnfjörð Bjarmason
2010-10-28 22:08 ` [PATCH v8 2/5] Raw diff output format for bulk moves Yann Dirson
2010-10-28 22:08 ` [PATCH v8 3/5] Add testcases for the --detect-bulk-moves diffcore flag Yann Dirson
2010-10-28 22:08 ` [PATCH v8 4/5] Unified diff output format for bulk moves Yann Dirson
2010-10-28 22:08 ` [PATCH v8 5/5] [WIP] Allow hiding renames of individual files involved in a directory rename Yann Dirson
2010-10-29 1:05 ` [PATCH v8] Detection of directory renames Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125150218.GA16049@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ydirson@altern.org \
--cc=ydirson@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).