From: Konstantin Khomoutov <flatworm@users.sourceforge.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Pat Thoyts <patthoyts@users.sourceforge.net>,
David Laban <alsuren+debbugs@gmail.com>
Subject: Re: git-gui: commit message box doesn't respond to enter (only return)
Date: Sat, 27 Nov 2010 02:28:25 +0300 [thread overview]
Message-ID: <20101126232825.GE3264@localhost.localdomain> (raw)
In-Reply-To: <20101126203855.GA23258@burratino>
On Fri, Nov 26, 2010 at 02:38:55PM -0600, Jonathan Nieder wrote:
> David Laban wrote at http://bugs.debian.org/605041:
>
> > Package: git-gui
> > Version: 1:1.7.2.3-2
> > Severity: minor
> >
> > If I click into the messagebox and hit enter, nothing happens.
> >
> > This is annoying because if I'm adding a new paragraph to my commit message,
> > I will often do <click> <enter><enter> <start typing as normal>
> >
> > Don't ask me why I do this. I think enter is a lighter/easier to press
> > key than return, and is also on the path that my hand takes between the mouse
> > and the rest of the keyboard.
> >
> > I have also provisionally reported the following bug in tk, but I feel like
> > a bit of a n00b for doing so.
> >
> > http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997
>
> I can't reproduce this because this laptop does not have a distinct
> "numpad enter" key.
I've tested it on Debian Squeeze and added another comment on the
upstream bug report. In short: KP_Enter is not bound to any action in
Tk text widgets in X11, at least in 8.5.9.
But git-gui can be trivially patched to support this; that would be a
one-lineer. So if it is desired and will be accepted, I could prepare a
patch.
next prev parent reply other threads:[~2010-11-26 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101126170956.25856.63131.reportbug@alsuren-thinkpad.cbg.collabora.co.uk>
2010-11-26 20:38 ` git-gui: commit message box doesn't respond to enter (only return) Jonathan Nieder
2010-11-26 23:28 ` Konstantin Khomoutov [this message]
2010-12-06 20:55 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126232825.GE3264@localhost.localdomain \
--to=flatworm@users.sourceforge.net \
--cc=alsuren+debbugs@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).