From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] entry.c: remove "checkout-index" from error messages
Date: Sun, 28 Nov 2010 01:30:47 -0500 [thread overview]
Message-ID: <20101128063046.GA2902@sigill.intra.peff.net> (raw)
In-Reply-To: <1290918998-15208-1-git-send-email-pclouds@gmail.com>
On Sun, Nov 28, 2010 at 11:36:38AM +0700, Nguyễn Thái Ngọc Duy wrote:
> Back then when entry.c was part of checkout-index (or checkout-cache
> at that time [1]). It makes sense to print the command name in error
> messages. Nowadays entry.c is in libgit and can be used by any
> commands, printing "git checkout-index: blah" does no more than
> confusion. The error messages without it still give enough information.
>
> [1] 12dccc1 (Make fiel checkout function available to the git library - 2005-06-05)
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> I attempted to replace "git checkout-index" with the actual command name
> when these functions are called, but I think it's better just removing
> it...
Agreed. This came up recently in another thread[1], and I also tracked
it down to a simple cut-and-paste from the original checkout-index.
Acked-by: Jeff King <peff@peff.net>
-Peff
[1] http://article.gmane.org/gmane.comp.version-control.git/160751
prev parent reply other threads:[~2010-11-28 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 4:36 [PATCH] entry.c: remove "checkout-index" from error messages Nguyễn Thái Ngọc Duy
2010-11-28 6:30 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128063046.GA2902@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).