Git development
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: Daniel Reichelt <debian@nachtgeist.net>,
	Jakub Narebski <jnareb@gmail.com>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active
Date: Sun, 28 Nov 2010 10:27:20 -0600	[thread overview]
Message-ID: <20101128162720.GB18335@burratino> (raw)
In-Reply-To: <20101128081048.13668.67286.reportbug@sb74.startrek>

Hi Jakub et al,

Daniel Reichelt wrote[1]:

> I just noticed that integrating gitweb via reverse proxy is impossible when
> path_info is enabled in gitweb.conf. The base href sent on gitweb.cgi:3427
> contains the "internal" URL called by the reverse proxy mechanism, not the
> original one called by the user agent which makes it impossible for the
> client to display CSS, images, etc...
> 
> I suggest an additional config variable, e.g.
> $feature{'pathinfo'}{'basehrefoverride'} which could override the base href
> tag determinted by the cgi script (or disable sending a base href tag at all
> - at least I was able to achieve my desired setup by adjusting the URLs for
> CSS etc in gitweb.conf to fitting absolute URLs).

Any advice for Daniel?  Is it a good idea?

Regards,
Jonathan

[1] http://bugs.debian.org/605217

       reply	other threads:[~2010-11-28 16:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20101128081048.13668.67286.reportbug@sb74.startrek>
2010-11-28 16:27 ` Jonathan Nieder [this message]
2010-11-28 17:25   ` gitweb: false base href sent when integrated via reverse proxy and path_info is active Giuseppe Bilotta
2010-11-28 17:47     ` Jakub Narebski
2010-11-28 18:12       ` Jonathan Nieder
2010-11-30 18:22         ` Jakub Narebski
2010-12-01  3:25           ` Junio C Hamano
2010-11-28 20:30       ` Daniel Reichelt
2010-11-28 21:07         ` Jakub Narebski
2010-11-28 21:25           ` Daniel Reichelt
2010-11-28 21:10         ` Jonathan Nieder
2010-11-28 21:28           ` Daniel Reichelt
2010-11-28 22:05           ` Jakub Narebski
2010-11-29  0:19             ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Jonathan Nieder
2010-11-29  0:51               ` [PATCH/RFC] gitweb/README: About $base_url etc. and $per_request_config Jakub Narebski
2010-11-29 17:57               ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101128162720.GB18335@burratino \
    --to=jrnieder@gmail.com \
    --cc=debian@nachtgeist.net \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox