From: Jakub Narebski <jnareb@gmail.com>
To: Daniel Reichelt <debian@nachtgeist.net>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active
Date: Sun, 28 Nov 2010 22:07:01 +0100 [thread overview]
Message-ID: <201011282207.03261.jnareb@gmail.com> (raw)
In-Reply-To: <4CF2BBEE.2050808@nachtgeist.net>
On Sun, 28 Nov 2010, Daniel Reichelt wrote:
>>> Lacking that, a plain
>>>
>>> our $base_url = 'whatever';
>>>
>>> in the gitweb config should probably work
>
> Nope again, I'm afraid it doesn't (see further down)
Strange, it works for me (see below).
>> See also gitweb/README, the "Gitweb config file variables" section:
>>
>> * $base_url
>> Base URL for relative URLs in pages generated by gitweb,
>> (e.g. $logo, $favicon, @stylesheets if they are relative URLs),
>> needed and used only for URLs with nonempty PATH_INFO via
>> <base href="$base_url">. Usually gitweb sets its value correctly,
>> ^^^^^^^
>> and there is no need to set this variable, e.g. to $my_uri or "/".
>>
>> The key word here is "usually" ;-)
>>
>
> *oops* thank you all for the hint! I totally missed that.
>
> However, I just tried that and it failed. $base_url gets ignored in
> gitweb.conf and even setting $my_url and $my_uri in gitweb.conf seems to
> have no effect at all. For testing purposes I printed the relevant
> variables to the html header:
>
>
> gitweb.conf:
> ************
The default name of gitweb config file is gitweb_config.perl, not
gitweb.conf. Are you sure you are picking correct config file?
> our $feature{'pathinfo'}{'default'} = [1];
> our $base_url = "https://foobar";
> our $my_url = "https://foo";
> our $my_uri = "https://bar";
Try adding
our $site_name = "foo";
to check if you are picking correct config file.
> - git summary of repo "test1"
> public url: https://sb74/projects/gitweb/test1/summary
> revProxy url: https://localhost:446/projects/gitweb/test1/summary
> ************
> <head>
> <meta http-equiv="content-type" content="application/xhtml+xml; charset=utf-8"/>
> <meta name="generator" content="gitweb/1.7.2.3 git/1.7.2.3"/>
> <meta name="robots" content="index, nofollow"/>
> <title>localhost Git - test1/summary</title>
> <base href="https://sb74:446/projects/gitweb" />
[...]
> </head>
I get the following when running with config file that contains:
our $version = "current";
[...]
our $site_name = "[localhost]";
[...]
our $base_url = "https://localhost/gitweb/";
$ gitweb-run.sh "" "/git.git"
[...]
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8"/>
<meta name="generator" content="gitweb/current git/1.7.3.2.171.g8ccd7"/>
<meta name="robots" content="index, nofollow"/>
<title>[localhost] - git.git/summary</title>
<base href="https://localhost/gitweb/" />
[...]
So it works for me.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-11-28 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101128081048.13668.67286.reportbug@sb74.startrek>
2010-11-28 16:27 ` gitweb: false base href sent when integrated via reverse proxy and path_info is active Jonathan Nieder
2010-11-28 17:25 ` Giuseppe Bilotta
2010-11-28 17:47 ` Jakub Narebski
2010-11-28 18:12 ` Jonathan Nieder
2010-11-30 18:22 ` Jakub Narebski
2010-12-01 3:25 ` Junio C Hamano
2010-11-28 20:30 ` Daniel Reichelt
2010-11-28 21:07 ` Jakub Narebski [this message]
2010-11-28 21:25 ` Daniel Reichelt
2010-11-28 21:10 ` Jonathan Nieder
2010-11-28 21:28 ` Daniel Reichelt
2010-11-28 22:05 ` Jakub Narebski
2010-11-29 0:19 ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Jonathan Nieder
2010-11-29 0:51 ` [PATCH/RFC] gitweb/README: About $base_url etc. and $per_request_config Jakub Narebski
2010-11-29 17:57 ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011282207.03261.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=debian@nachtgeist.net \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).