From: Jonathan Nieder <jrnieder@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/6] web--browse: split valid_tool list
Date: Mon, 29 Nov 2010 10:44:35 -0600 [thread overview]
Message-ID: <20101129164435.GI8037@burratino> (raw)
In-Reply-To: <1291042075-19983-4-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta wrote:
> --- a/git-web--browse.sh
> +++ b/git-web--browse.sh
> @@ -31,7 +31,8 @@ valid_custom_tool()
>
> valid_tool() {
> case "$1" in
> - firefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)
> + firefox|iceweasel|chrome|google-chrome|chromium\
> + |konqueror|w3m|links|lynx|dillo|open|start)
micronit: I think this looks better as
firefox|iceweasel|chrome|google-chrome|chromium| \
konqueror|w3m|links|lynx|dillo|open|start)
, with the | on the end of the first line.
next prev parent reply other threads:[~2010-11-29 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:47 [PATCH 0/6] web--browse cleanups and extensions Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 1/6] CodingGuidelines: mention whitespace preferences for shell scripts Giuseppe Bilotta
2010-11-30 0:30 ` Junio C Hamano
2010-11-30 8:11 ` Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 2/6] web--browse: coding style Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 3/6] web--browse: split valid_tool list Giuseppe Bilotta
2010-11-29 16:44 ` Jonathan Nieder [this message]
2010-11-29 19:19 ` Giuseppe Bilotta
2010-11-29 20:24 ` Junio C Hamano
2010-11-29 14:47 ` [PATCH 4/6] web--browse: support opera, seamonkey and elinks Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 5/6] web--browse: use (x-)www-browser if available Giuseppe Bilotta
2010-11-29 16:18 ` Christian Couder
2010-11-29 16:25 ` Christian Couder
2010-11-29 19:05 ` Giuseppe Bilotta
2010-11-30 4:02 ` Christian Couder
2010-11-30 8:22 ` Giuseppe Bilotta
2010-12-01 10:59 ` Christian Couder
2010-12-01 11:46 ` Giuseppe Bilotta
2010-12-01 15:49 ` Jonathan Nieder
2010-11-29 16:48 ` Jonathan Nieder
2010-11-29 19:16 ` Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 6/6] web--browse: special-case chromium path Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129164435.GI8037@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).