From: Jonathan Nieder <jrnieder@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Jeremy Huddleston <jeremyhu@apple.com>, git@vger.kernel.org
Subject: Re: [PATCH] Fallback on _NSGetExecutablePath to get the executable path if using argv[0] fails
Date: Mon, 29 Nov 2010 11:12:11 -0600 [thread overview]
Message-ID: <20101129171211.GL8037@burratino> (raw)
In-Reply-To: <AANLkTimwRJqje1-HhzKj-L-5-2CvhTC0+Pr0Cvj7d_kc@mail.gmail.com>
Thiago Farina wrote:
> On Mon, Nov 29, 2010 at 2:57 PM, Jeremy Huddleston <jeremyhu@apple.com> wrote:
>> Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
>> Reviewed-by: Matt Wright <mww@apple.com>
I like the idea, but could you add a short commit message
explaining the existing behavior and what improvement this makes?
> Why not #if defined(__APPLE__), like above?
More importantly, please search for #ifdef in existing code to get
some examples of how we like to do platform-specific things.
The section "2) #ifdefs are ugly" of
linux-2.6/Documentation/SubmittingPatches explains the rationale.
Regards,
Jonathan
next prev parent reply other threads:[~2010-11-29 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 16:57 [PATCH] Fallback on _NSGetExecutablePath to get the executable path if using argv[0] fails Jeremy Huddleston
2010-11-29 17:09 ` Thiago Farina
2010-11-29 17:12 ` Jonathan Nieder [this message]
2010-11-29 18:29 ` [PATCH updated] " Jeremy Huddleston
2010-11-29 18:49 ` Jonathan Nieder
2010-11-29 20:24 ` Junio C Hamano
2010-11-29 21:02 ` Jeremy Huddleston
2010-11-29 18:34 ` [PATCH] " Jeremy Huddleston
2010-11-29 18:50 ` Jonathan Nieder
2010-11-29 20:07 ` Jeremy Huddleston
2010-11-29 20:19 ` Jonathan Nieder
2010-11-29 23:13 ` Kevin Ballard
2010-12-03 7:42 ` Jonathan Nieder
2010-12-03 7:50 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129171211.GL8037@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeremyhu@apple.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).