From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Make the tab width used for whitespace checks configurable
Date: Mon, 29 Nov 2010 11:16:29 -0600 [thread overview]
Message-ID: <20101129171629.GM8037@burratino> (raw)
In-Reply-To: <4CF366B1.8070400@viscovery.net>
Johannes Sixt wrote:
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> I have a project that uses tab width 4, and which has a lot of whitespace
> errors. This is very helpful to spot them when lines are changed that
> are indented with 4 spaces.
Thanks.
For what it's worth, I like the idea and the patch looks good.
(I haven't checked for missed spots or read the test in detail,
though.)
> + if (0 < tabwidth && tabwidth < 0100)
> + rule &= ~WS_TAB_WIDTH_MASK, rule |= tabwidth;
Tab widths are recognized with atoi and out-of-range tab widths are
silently ignored. Could we help the user spot typos somehow?
next prev parent reply other threads:[~2010-11-29 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 8:39 [PATCH] Make the tab width used for whitespace checks configurable Johannes Sixt
2010-11-29 17:16 ` Jonathan Nieder [this message]
2010-11-30 1:31 ` Junio C Hamano
2010-11-30 8:22 ` [PATCH 1/2 maint] apply --whitespace=fix: fix tab-in-indent Johannes Sixt
2010-11-30 8:29 ` [PATCH 2/2 v2] Make the tab width used for whitespace checks configurable Johannes Sixt
2010-11-30 23:19 ` [PATCH 1/2 maint] apply --whitespace=fix: fix tab-in-indent Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129171629.GM8037@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).