git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
	git@vger.kernel.org, Daniel Reichelt <debian@nachtgeist.net>
Subject: Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active
Date: Tue, 30 Nov 2010 19:22:09 +0100	[thread overview]
Message-ID: <201011301922.11695.jnareb@gmail.com> (raw)
In-Reply-To: <20101128181215.GB19545@burratino>

On Sun, 28 Nov 2010, Jonathan Nieder wrote:
> Jakub Narebski wrote:
> 
> > See also gitweb/README, the "Gitweb config file variables" section:
> > 
> >  * $base_url
> >    Base URL for relative URLs in pages generated by gitweb,
> >    (e.g. $logo, $favicon, @stylesheets if they are relative URLs),
> >    needed and used only for URLs with nonempty PATH_INFO via
> >    <base href="$base_url">.  Usually gitweb sets its value correctly,
> >                              ^^^^^^^
> >    and there is no need to set this variable, e.g. to $my_uri or "/".
> > 
> > The key word here is "usually" ;-)
> 
> Thanks, all.  That helps.
> 
> No time for it at the moment, but I'm taking this as evidence that
> we need a gitweb.conf(5) manual page. :)  Would you be interested
> in such a thing (as POD or asciidoc)?

Well, both git-gui and gitk have their documentation in Documentation/
(in AsciiDoc format), so perhaps it is time to add Documentation/gitweb.txt
and possibly also Documentation/gitweb_config.txt (or gitweb.conf.txt).

With exception of t/README, the gitweb/README file is largest, with around
570 lines, while next largest is (discarding also git-gui/po/README) main
README file with around 50 lines.
-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-11-30 18:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20101128081048.13668.67286.reportbug@sb74.startrek>
2010-11-28 16:27 ` gitweb: false base href sent when integrated via reverse proxy and path_info is active Jonathan Nieder
2010-11-28 17:25   ` Giuseppe Bilotta
2010-11-28 17:47     ` Jakub Narebski
2010-11-28 18:12       ` Jonathan Nieder
2010-11-30 18:22         ` Jakub Narebski [this message]
2010-12-01  3:25           ` Junio C Hamano
2010-11-28 20:30       ` Daniel Reichelt
2010-11-28 21:07         ` Jakub Narebski
2010-11-28 21:25           ` Daniel Reichelt
2010-11-28 21:10         ` Jonathan Nieder
2010-11-28 21:28           ` Daniel Reichelt
2010-11-28 22:05           ` Jakub Narebski
2010-11-29  0:19             ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Jonathan Nieder
2010-11-29  0:51               ` [PATCH/RFC] gitweb/README: About $base_url etc. and $per_request_config Jakub Narebski
2010-11-29 17:57               ` [PATCH/RFC] gitweb: Preserve $base_url if it was set Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011301922.11695.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=debian@nachtgeist.net \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).