From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active Date: Tue, 30 Nov 2010 19:22:09 +0100 Message-ID: <201011301922.11695.jnareb@gmail.com> References: <20101128081048.13668.67286.reportbug@sb74.startrek> <201011281847.40233.jnareb@gmail.com> <20101128181215.GB19545@burratino> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Giuseppe Bilotta , git@vger.kernel.org, Daniel Reichelt To: Jonathan Nieder X-From: git-owner@vger.kernel.org Tue Nov 30 19:22:49 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PNUqm-0002oX-Bp for gcvg-git-2@lo.gmane.org; Tue, 30 Nov 2010 19:22:48 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100Ab0K3SW2 (ORCPT ); Tue, 30 Nov 2010 13:22:28 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:44862 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756124Ab0K3SWZ (ORCPT ); Tue, 30 Nov 2010 13:22:25 -0500 Received: by bwz15 with SMTP id 15so5283306bwz.19 for ; Tue, 30 Nov 2010 10:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=3A297B1jCilKZ41uYeQiJtAoG7vp3bRbwJKilfEQnF4=; b=OIg3Edyw9DYG8ktV5fZreZFvrAmZ0NGCV7UvKiPOjJnI+qa9f2wYMy45K/ccxpvPGj wL3vclEsFegn1pOgvQoeIQjoyl7tMxRrwdI9KRl5f96rg6GwYT4RJ7bsh4IEQ497W5DD 0zqC97yA/Z52GQ+kGk8oQecUBMXpewzbT7TBw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=OB/BS4vsWw8/ujQTKMkEqp1XS3egiUUqoT9I4/S7GIc/uAWPzMkepWC468jB8Ih98Q FGuWLUWW0jzlNklyoV9SkMkO3QnTz7RylXCbpis0p95vYt95HrkMcBa1ep2eUKZC0SSw KqEv0MnBjGjc/Z3wUlrPxo8reRPqj6+2kbG9o= Received: by 10.204.97.146 with SMTP id l18mr7242865bkn.118.1291141344004; Tue, 30 Nov 2010 10:22:24 -0800 (PST) Received: from [192.168.1.13] (abwm72.neoplus.adsl.tpnet.pl [83.8.236.72]) by mx.google.com with ESMTPS id a24sm615011fak.3.2010.11.30.10.22.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Nov 2010 10:22:21 -0800 (PST) User-Agent: KMail/1.9.3 In-Reply-To: <20101128181215.GB19545@burratino> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, 28 Nov 2010, Jonathan Nieder wrote: > Jakub Narebski wrote: > > > See also gitweb/README, the "Gitweb config file variables" section: > > > > * $base_url > > Base URL for relative URLs in pages generated by gitweb, > > (e.g. $logo, $favicon, @stylesheets if they are relative URLs), > > needed and used only for URLs with nonempty PATH_INFO via > > . Usually gitweb sets its value correctly, > > ^^^^^^^ > > and there is no need to set this variable, e.g. to $my_uri or "/". > > > > The key word here is "usually" ;-) > > Thanks, all. That helps. > > No time for it at the moment, but I'm taking this as evidence that > we need a gitweb.conf(5) manual page. :) Would you be interested > in such a thing (as POD or asciidoc)? Well, both git-gui and gitk have their documentation in Documentation/ (in AsciiDoc format), so perhaps it is time to add Documentation/gitweb.txt and possibly also Documentation/gitweb_config.txt (or gitweb.conf.txt). With exception of t/README, the gitweb/README file is largest, with around 570 lines, while next largest is (discarding also git-gui/po/README) main README file with around 50 lines. -- Jakub Narebski Poland