From: Chris Webb <chris@arachsys.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 1/2 maint] apply --whitespace=fix: fix tab-in-indent
Date: Tue, 30 Nov 2010 23:19:10 +0000 [thread overview]
Message-ID: <20101130231909.GA2425@arachsys.com> (raw)
In-Reply-To: <4CF4B42C.4080104@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
> When the whitespace rule tab-in-indent is enabled, apply --whitespace=fix
> replaces tabs by the appropriate amount of blanks. The code used
> "dst->len % 8" as the criterion to stop adding blanks. But it forgot that
> dst holds more than just the current line. Consequently, the modulus was
> computed correctly only for the first added line, but not for the second
> and subsequent lines. Fix it.
You're quite right! My mistake, so if you like, please feel free to add
Acked-by: Chris Webb <chris@arachsys.com>
Cheers,
Chris.
prev parent reply other threads:[~2010-11-30 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 8:39 [PATCH] Make the tab width used for whitespace checks configurable Johannes Sixt
2010-11-29 17:16 ` Jonathan Nieder
2010-11-30 1:31 ` Junio C Hamano
2010-11-30 8:22 ` [PATCH 1/2 maint] apply --whitespace=fix: fix tab-in-indent Johannes Sixt
2010-11-30 8:29 ` [PATCH 2/2 v2] Make the tab width used for whitespace checks configurable Johannes Sixt
2010-11-30 23:19 ` Chris Webb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130231909.GA2425@arachsys.com \
--to=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).