From: Jonathan Nieder <jrnieder@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 5/6] web--browse: use (x-)www-browser if available
Date: Wed, 1 Dec 2010 09:49:59 -0600 [thread overview]
Message-ID: <20101201154959.GA26120@burratino> (raw)
In-Reply-To: <AANLkTikfAr-KUVyqeTooxYKvKWYM4pRmw51if+349dpJ@mail.gmail.com>
Giuseppe Bilotta wrote:
> I will look into adding support for the BROWSER environment variable
> to select the browser if no browser is defined
Thanks, that sounds excellent.
BTW, the semantics of quoting characters/shell metacharacters in
$BROWSER are not well defined (well, they're well defined in one way
by the original spec, which is ignored by xdg-open and some other
tools). xdg-open's semantics are probably the most reliable standard
here but thought I should give a heads up.
Thinking out loud: longer term, it would be nice to just use xdg-utils
and drop most of this logic from git. Presumably the ideal behavior
for most apps opening web pages is already "new tab", so the cases of
"new window" not explicitly configured that way by the user are bugs.
Otherwise a request to portland@lists.freedesktop.org (subscription
required) for xdg-open --new-tab/--new-window might be useful.
Regards,
Jonathan
next prev parent reply other threads:[~2010-12-01 15:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:47 [PATCH 0/6] web--browse cleanups and extensions Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 1/6] CodingGuidelines: mention whitespace preferences for shell scripts Giuseppe Bilotta
2010-11-30 0:30 ` Junio C Hamano
2010-11-30 8:11 ` Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 2/6] web--browse: coding style Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 3/6] web--browse: split valid_tool list Giuseppe Bilotta
2010-11-29 16:44 ` Jonathan Nieder
2010-11-29 19:19 ` Giuseppe Bilotta
2010-11-29 20:24 ` Junio C Hamano
2010-11-29 14:47 ` [PATCH 4/6] web--browse: support opera, seamonkey and elinks Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 5/6] web--browse: use (x-)www-browser if available Giuseppe Bilotta
2010-11-29 16:18 ` Christian Couder
2010-11-29 16:25 ` Christian Couder
2010-11-29 19:05 ` Giuseppe Bilotta
2010-11-30 4:02 ` Christian Couder
2010-11-30 8:22 ` Giuseppe Bilotta
2010-12-01 10:59 ` Christian Couder
2010-12-01 11:46 ` Giuseppe Bilotta
2010-12-01 15:49 ` Jonathan Nieder [this message]
2010-11-29 16:48 ` Jonathan Nieder
2010-11-29 19:16 ` Giuseppe Bilotta
2010-11-29 14:47 ` [PATCH 6/6] web--browse: special-case chromium path Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201154959.GA26120@burratino \
--to=jrnieder@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).