git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: jari.aalto@cante.net
Cc: git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>,
	Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH v3] Documentation/config.txt: Order variables alphabetically
Date: Wed, 1 Dec 2010 10:13:11 -0600	[thread overview]
Message-ID: <20101201161311.GC26120@burratino> (raw)
In-Reply-To: <31def5a4a6256e6fdef8a03372cda98460f61c47.1291217124.git.jari.aalto@cante.net>

Hi,

jari.aalto@cante.net wrote:

> From: Jari Aalto <jari.aalto@cante.net>

Could you or some other interested person give a diff of just the
lines with ::, as well as confirming that the other lines did not
change, only shuffled around?  It would be nice to get a sense of the
net effect of the change.

Regardless of the answer, it needs justification _in the log message_.
Putting this in alphabetical order may make it easier for people to
decide where to add their future config variables, but they will
wonder why that order, and whether it is worth changing again.

FWIW the "my man pager is broken" justification doesn't seem so strong
to me.  The "my hardcopy of the manual doesn't have an easy search
function" seems more compelling, except that there is work in progress
to fix that by splitting documentation of config vars by affected
command and making gitconfig(5) proper into an index.

Hope that helps,
Jonathan

      reply	other threads:[~2010-12-01 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 12:48 GIT connect "connect to host HOSTNAME port 22: Bad file number" message shown GAURAV BAHL
2010-12-01 13:33 ` [msysGit] " Erik Faye-Lund
     [not found]   ` <AANLkTimCgHwXfYJveFFKK3JEa6j3rieeQMzxxHzFVZ9f@mail.gmail.com>
2010-12-01 14:19     ` Erik Faye-Lund
2010-12-01 14:41 ` [PATCH v2] Documentation/config.txt: Order variables alphabetically Jari Aalto
2010-12-01 15:25   ` [PATCH v3] " jari.aalto
2010-12-01 16:13     ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201161311.GC26120@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jari.aalto@cante.net \
    --cc=jnareb@gmail.com \
    --cc=kusmabite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).