From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, Klaus Ethgen <Klaus@Ethgen.de>,
Sven Verdoolaege <skimo@kotnet.org>,
mlevedahl@gmail.com, ben@ben.com
Subject: Re: [RFC/PATCH] Re: git submodule -b ... of current HEAD fails
Date: Fri, 3 Dec 2010 01:10:37 -0600 [thread overview]
Message-ID: <20101203071037.GA18202@burratino> (raw)
In-Reply-To: <4CF80B71.3010309@web.de>
Jens Lehmann wrote:
> Am 01.12.2010 19:50, schrieb Jonathan Nieder:
>> Jens, any idea why git submodule
>> is not using "clone --branch" directly?
>
> Nope, these lines date back to the time before I got involved in the
> submodule business ... Seems like this "git checkout" was added in
> March 2008 by Mark Levedahl (CCed), maybe he can shed some light on
> that.
Ah, so the problem is that "clone --branch" did not exist. Sorry for
the noise.
Another question can be also be easily answered by history examination:
the series of checks in module_clone are because 70c7ac22d:git-clone.sh
did not have checks of its own for the target directory.
So there is some simplification within grasp.
'night,
Jonathan
next prev parent reply other threads:[~2010-12-03 7:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101201171814.GC6439@ikki.ethgen.de>
2010-12-01 18:50 ` [RFC/PATCH] Re: git submodule -b ... of current HEAD fails Jonathan Nieder
2010-12-02 21:11 ` Jens Lehmann
2010-12-03 1:16 ` Mark Levedahl
2010-12-03 1:21 ` Ben Jackson
2010-12-03 7:10 ` Jonathan Nieder [this message]
2010-12-04 23:27 ` [PATCH] git submodule: Remove now obsolete tests before cloning a repo Jens Lehmann
2010-12-07 22:57 ` [RFC/PATCH] Re: git submodule -b ... of current HEAD fails Junio C Hamano
2010-12-08 21:35 ` Jens Lehmann
2010-12-08 23:19 ` [PATCH] " Jens Lehmann
2010-12-08 23:45 ` Jonathan Nieder
2010-12-28 21:42 ` [RFC/PATCH] " Junio C Hamano
2010-12-29 0:05 ` Jens Lehmann
2010-12-29 0:34 ` Junio C Hamano
2010-12-29 9:04 ` Jens Lehmann
2010-12-29 20:53 ` Re* " Junio C Hamano
[not found] ` <4D1BB26D.1010502@web.de>
2010-12-29 22:23 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203071037.GA18202@burratino \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=Klaus@Ethgen.de \
--cc=ben@ben.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
--cc=skimo@kotnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).