From: Jonathan Nieder <jrnieder@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2 7/7] web--browse: look at the BROWSER env var
Date: Fri, 3 Dec 2010 11:16:28 -0600 [thread overview]
Message-ID: <20101203171628.GA13721@burratino> (raw)
In-Reply-To: <20101203170800.GE12910@burratino>
Jonathan Nieder wrote:
> Giuseppe Bilotta wrote:
>> --- a/git-web--browse.sh
>> +++ b/git-web--browse.sh
>> @@ -138,6 +138,51 @@ then
>[...]
>> +if test -z "$browser" -a -n "$BROWSER"; then
>> + OLDIFS="$IFS"
>> + IFS=:
>[...]
>> + IFS="$OLDIFS"
>
> Micronit: on some shells (e.g., old ash[1]), IFS starts out unset if
> it hasn't been inherited in the environment.
Of course, we are using this idiom in a few places already, so that
can be saved for another topic. Sorry for not checking sooner.
prev parent reply other threads:[~2010-12-03 17:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:47 [PATCHv2 0/7] web--browse cleanup and extensions Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 1/7] CodingGuidelines: mention whitespace preferences for shell scripts Giuseppe Bilotta
2010-12-03 21:43 ` Junio C Hamano
2010-12-03 22:02 ` Giuseppe Bilotta
2010-12-03 22:28 ` Junio C Hamano
2010-12-03 22:46 ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 2/7] web--browse: coding style Giuseppe Bilotta
2010-12-07 23:38 ` Junio C Hamano
2010-12-03 16:47 ` [PATCHv2 3/7] web--browse: split valid_tool list Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 4/7] web--browse: support opera, seamonkey and elinks Giuseppe Bilotta
2010-12-03 22:01 ` Junio C Hamano
2010-12-03 22:22 ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 5/7] web--browse: better support for chromium Giuseppe Bilotta
2010-12-03 21:57 ` Junio C Hamano
2010-12-03 22:25 ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 6/7] web--browse: use (x-)www-browser if available Giuseppe Bilotta
2010-12-03 17:40 ` Christian Couder
2010-12-03 17:57 ` Giuseppe Bilotta
2010-12-03 22:15 ` Junio C Hamano
2010-12-03 22:45 ` Giuseppe Bilotta
2010-12-04 0:42 ` Jonathan Nieder
2010-12-04 7:49 ` Giuseppe Bilotta
2010-12-03 16:47 ` [PATCHv2 7/7] web--browse: look at the BROWSER env var Giuseppe Bilotta
2010-12-03 17:08 ` Jonathan Nieder
2010-12-03 17:16 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203171628.GA13721@burratino \
--to=jrnieder@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).