From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning
Date: Sat, 4 Dec 2010 14:52:06 -0600 [thread overview]
Message-ID: <20101204205206.GB3170@burratino> (raw)
In-Reply-To: <4CFA92A2.4030801@ramsay1.demon.co.uk>
Ramsay Jones wrote:
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -149,7 +149,7 @@ static void wt_status_print_change_data(struct wt_status *s,
> {
> struct wt_status_change_data *d = it->util;
> const char *c = color(change_type, s);
> - int status = status;
> + int status = 0;
Just for the record (I assume you are already aware of this):
http://thread.gmane.org/gmane.comp.version-control.git/133278/focus=133422
http://thread.gmane.org/gmane.comp.version-control.git/124676/focus=124803
I personally feel lukewarm about this kind of change. Is it possible to
suppress this warning from msvc?
next prev parent reply other threads:[~2010-12-04 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 19:12 [PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning Ramsay Jones
2010-12-04 20:52 ` Jonathan Nieder [this message]
2010-12-09 18:17 ` Ramsay Jones
2010-12-09 19:08 ` Junio C Hamano
2010-12-09 19:46 ` Erik Faye-Lund
2010-12-10 13:35 ` Sebastian Schuberth
2010-12-10 15:05 ` Erik Faye-Lund
2010-12-10 15:43 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101204205206.GB3170@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).