From: Johannes Sixt <j6t@kdbg.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
"GIT Mailing-list" <git@vger.kernel.org>,
sschuberth@gmail.com
Subject: Re: [PATCH 04/14] msvc: Fix macro redefinition warnings
Date: Sat, 4 Dec 2010 22:04:51 +0100 [thread overview]
Message-ID: <201012042204.52002.j6t@kdbg.org> (raw)
In-Reply-To: <4CFA8FE3.1050009@ramsay1.demon.co.uk>
On Samstag, 4. Dezember 2010, Ramsay Jones wrote:
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -14,12 +14,6 @@ typedef int socklen_t;
> #define S_ISLNK(x) (((x) & S_IFMT) == S_IFLNK)
> #define S_ISSOCK(x) 0
>
> -#ifndef _STAT_H_
Instead of removing the macros, wouldn't we be much safer with just
#ifndef S_IWUSR
? I suggest S_IWUSR because it is used inside #ifdef WIN32 brackets in
test-chmtime.c and seems to be more important than the others :-)
> -#define S_IRUSR 0
> -#define S_IWUSR 0
> -#define S_IXUSR 0
> -#define S_IRWXU (S_IRUSR | S_IWUSR | S_IXUSR)
> -#endif
> #define S_IRGRP 0
> #define S_IWGRP 0
> #define S_IXGRP 0
-- Hannes
next prev parent reply other threads:[~2010-12-04 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 19:00 [PATCH 04/14] msvc: Fix macro redefinition warnings Ramsay Jones
2010-12-04 21:04 ` Johannes Sixt [this message]
2010-12-08 0:05 ` Ramsay Jones
2010-12-08 10:32 ` Sebastian Schuberth
2010-12-08 19:51 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012042204.52002.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).