From: Thomas Rast <trast@student.ethz.ch>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Anders Kaseorg" <andersk@ksplice.com>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Kirill Smelkov" <kirr@mns.spb.ru>
Subject: Re: [PATCH] describe: Don’t look up commits with --exact-match
Date: Mon, 6 Dec 2010 11:53:59 +0100 [thread overview]
Message-ID: <201012061153.59635.trast@student.ethz.ch> (raw)
In-Reply-To: <20101206073214.GA3745@burratino>
Jonathan Nieder wrote:
> Anders Kaseorg wrote:
> > On Fri, 3 Dec 2010, Jonathan Nieder wrote:
>
> >> Instead of looking up the commit to be matched exactly in the commits
> >> hash table, this makes a linear search.
> [...]
> > I don’t think it’s ever a problem: in my repository with 1800 tags on a
> > warm cache, that loop accounts for about 0.1% of even the fastest
> > non-exact-match query (a commit right after a tag).
>
> Thanks for checking. Makes sense.
Apart from measuring: for_each_ref *loads* the tags in a linear scan,
so another linear scan doesn't add to the runtime w.r.t. number of
tags. It only hurts if you also describe many refs in one go.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-12-06 10:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 23:33 [PATCH] describe: Don’t look up commits with --exact-match Anders Kaseorg
2010-12-03 8:43 ` Jonathan Nieder
2010-12-06 7:19 ` Anders Kaseorg
2010-12-06 7:22 ` Anders Kaseorg
2010-12-06 7:32 ` Jonathan Nieder
2010-12-06 10:53 ` Thomas Rast [this message]
2010-12-06 17:28 ` Anders Kaseorg
2010-12-06 17:47 ` Jonathan Nieder
2010-12-07 9:58 ` SZEDER Gábor
2010-12-07 18:22 ` [PATCH 1/2] describe: Use for_each_rawref Anders Kaseorg
2010-12-07 18:22 ` [PATCH 2/2] describe: Don’t look up commits with --exact-match Anders Kaseorg
2010-12-07 18:26 ` [PATCH 1/2] describe: Use for_each_rawref Anders Kaseorg
2010-12-07 19:49 ` Junio C Hamano
2010-12-07 21:59 ` Junio C Hamano
2010-12-07 18:39 ` [PATCH] describe: Don’t look up commits with --exact-match Junio C Hamano
2010-12-08 4:41 ` Anders Kaseorg
2010-12-08 4:42 ` [PATCH v2 1/4] describe: Use for_each_rawref Anders Kaseorg
2010-12-08 4:43 ` [PATCH v2 2/4] describe: Don’t use a flex array in struct commit_name Anders Kaseorg
2010-12-08 4:43 ` [PATCH v2 3/4] describe: Store commit_names in a hash table by commit SHA1 Anders Kaseorg
2010-12-08 18:23 ` [PATCH v2.1 " Anders Kaseorg
2010-12-08 22:50 ` Junio C Hamano
2010-12-08 4:46 ` [PATCH v2 4/4] describe: Delay looking up commits until searching for an inexact match Anders Kaseorg
2010-12-08 22:50 ` Junio C Hamano
2010-12-08 23:47 ` Anders Kaseorg
2010-12-09 6:42 ` [PATCH v3 1/4] describe: Use for_each_rawref Anders Kaseorg
2010-12-09 6:43 ` [PATCH v3 2/4] describe: Don’t use a flex array in struct commit_name Anders Kaseorg
2010-12-09 6:46 ` [PATCH v3 3/4] describe: Store commit_names in a hash table by commit SHA1 Anders Kaseorg
2010-12-09 6:47 ` [PATCH v3 4/4] describe: Delay looking up commits until searching for an inexact match Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012061153.59635.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=andersk@ksplice.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kirr@mns.spb.ru \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).