From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Anders Kaseorg <andersk@ksplice.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Kirill Smelkov <kirr@mns.spb.ru>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] describe: Don’t look up commits with --exact-match
Date: Tue, 7 Dec 2010 10:58:18 +0100 [thread overview]
Message-ID: <20101207095818.GB1867@neumann> (raw)
In-Reply-To: <alpine.DEB.2.02.1012061159500.23348@dr-wily.mit.edu>
Hi,
On Mon, Dec 06, 2010 at 12:28:59PM -0500, Anders Kaseorg wrote:
> This makes ‘git describe --exact-match HEAD’ about 15 times faster on
> a cold cache (2.3s instead of 35s) in a linux-2.6 repository with many
> packed tags. That’s a huge win for the interactivity of the __git_ps1
> shell prompt helper.
I wanted to give it a try to see the performance improvements in the
bash prompt for myself, but couldn't get to it so far. However,
glancing through the logic finding out the current branch in
__git_ps1, it seems that git describe is only run when git
symbolic-ref HEAD failed, i.e. when on a detached head. So the
performance improvement in the shell prompt is only there when on a
detached head (and with lots of tags), right? If so, then I'd like to
have "when on a detached head" appended to the commit message.
Best,
Gábor
next prev parent reply other threads:[~2010-12-07 9:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 23:33 [PATCH] describe: Don’t look up commits with --exact-match Anders Kaseorg
2010-12-03 8:43 ` Jonathan Nieder
2010-12-06 7:19 ` Anders Kaseorg
2010-12-06 7:22 ` Anders Kaseorg
2010-12-06 7:32 ` Jonathan Nieder
2010-12-06 10:53 ` Thomas Rast
2010-12-06 17:28 ` Anders Kaseorg
2010-12-06 17:47 ` Jonathan Nieder
2010-12-07 9:58 ` SZEDER Gábor [this message]
2010-12-07 18:22 ` [PATCH 1/2] describe: Use for_each_rawref Anders Kaseorg
2010-12-07 18:22 ` [PATCH 2/2] describe: Don’t look up commits with --exact-match Anders Kaseorg
2010-12-07 18:26 ` [PATCH 1/2] describe: Use for_each_rawref Anders Kaseorg
2010-12-07 19:49 ` Junio C Hamano
2010-12-07 21:59 ` Junio C Hamano
2010-12-07 18:39 ` [PATCH] describe: Don’t look up commits with --exact-match Junio C Hamano
2010-12-08 4:41 ` Anders Kaseorg
2010-12-08 4:42 ` [PATCH v2 1/4] describe: Use for_each_rawref Anders Kaseorg
2010-12-08 4:43 ` [PATCH v2 2/4] describe: Don’t use a flex array in struct commit_name Anders Kaseorg
2010-12-08 4:43 ` [PATCH v2 3/4] describe: Store commit_names in a hash table by commit SHA1 Anders Kaseorg
2010-12-08 18:23 ` [PATCH v2.1 " Anders Kaseorg
2010-12-08 22:50 ` Junio C Hamano
2010-12-08 4:46 ` [PATCH v2 4/4] describe: Delay looking up commits until searching for an inexact match Anders Kaseorg
2010-12-08 22:50 ` Junio C Hamano
2010-12-08 23:47 ` Anders Kaseorg
2010-12-09 6:42 ` [PATCH v3 1/4] describe: Use for_each_rawref Anders Kaseorg
2010-12-09 6:43 ` [PATCH v3 2/4] describe: Don’t use a flex array in struct commit_name Anders Kaseorg
2010-12-09 6:46 ` [PATCH v3 3/4] describe: Store commit_names in a hash table by commit SHA1 Anders Kaseorg
2010-12-09 6:47 ` [PATCH v3 4/4] describe: Delay looking up commits until searching for an inexact match Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207095818.GB1867@neumann \
--to=szeder@ira.uka.de \
--cc=andersk@ksplice.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kirr@mns.spb.ru \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).