From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-rm.txt: Fix quoting
Date: Tue, 7 Dec 2010 12:25:42 -0500 [thread overview]
Message-ID: <20101207172542.GA25827@sigill.intra.peff.net> (raw)
In-Reply-To: <20101207171939.GA21105@burratino>
On Tue, Dec 07, 2010 at 11:19:39AM -0600, Jonathan Nieder wrote:
> Michael J Gruber wrote:
>
> > --- a/Documentation/git-rm.txt
> > +++ b/Documentation/git-rm.txt
> > @@ -111,8 +111,8 @@ tree using this command:
> > git ls-files -z | xargs -0 rm -f
> > ----------------
> >
> > -and then "untar" the new code in the working tree. Alternately
> > -you could "rsync" the changes into the working tree.
> > +and then `untar` the new code in the working tree. Alternately
> > +you could `rsync` the changes into the working tree.
>
> I like the patch. Is there really an "untar" command?
Heh. Yeah, I was so caught up in looking at formatting that I didn't
think about the actual meaning. :) Untar should definitely not be a
literal (and should not have been quoted in the first place).
> Maybe something like this on top? ('rsync' is in italics because it
> is just a command name rather than a full command ready to be typed on
> the command line.)
No opinion on that from me.
> Using ``git commit -a''
> -~~~~~~~~~~~~~~~~~~~~~
> +~~~~~~~~~~~~~~~~~~~~~~~
I think this length doesn't have to match the text above, but I agree it
looks better to viewers of the source if it does.
-Peff
next prev parent reply other threads:[~2010-12-07 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 5:07 [BUG] yet another doc formatting problem Jeff King
2010-12-07 8:42 ` Michael J Gruber
2010-12-07 9:07 ` [PATCH] git-rm.txt: Fix quoting Michael J Gruber
2010-12-07 16:43 ` Jeff King
2010-12-08 8:08 ` Michael J Gruber
2010-12-07 17:19 ` Jonathan Nieder
2010-12-07 17:25 ` Jeff King [this message]
2010-12-08 11:15 ` [PATCHv2] " Michael J Gruber
2010-12-07 19:12 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207172542.GA25827@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).