From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] logging branch deletion to help recovering from mistakes
Date: Tue, 7 Dec 2010 10:37:39 -0800 [thread overview]
Message-ID: <20101207183739.GB3725@spearce.org> (raw)
In-Reply-To: <20101207183507.GA27277@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Tue, Dec 07, 2010 at 10:23:42AM -0800, Shawn O. Pearce wrote:
>
> > Yea, I'm leaning more towards the foo..deleted-n idea too, for the
> > same reasons. It also makes it easier to GC a deleted branch's
> > reflog, we can examine the last record's timestamp in a reasonable
> > time bound and unlink the log if its really freaking old.
>
> Do we need to actually do that? Shouldn't the entries in the reflog get
> expired as part of the regular reflog gc? In that case, we would just
> delete the file when it had zero entries.
Yes, you are right. We should instead let the normal reflog expire
action do its work here, and delete the empty log file when it is
finally empty.
I guess we also need repack and prune to enumerate these deleted
reflogs and retain the objects their records point to.
--
Shawn.
next prev parent reply other threads:[~2010-12-07 18:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 21:16 [PATCH] logging branch deletion to help recovering from mistakes Junio C Hamano
2010-12-06 21:55 ` Štěpán Němec
2010-12-06 23:14 ` Andreas Schwab
2010-12-07 1:18 ` Nguyen Thai Ngoc Duy
2010-12-07 6:28 ` Junio C Hamano
2010-12-07 11:37 ` Nguyen Thai Ngoc Duy
2010-12-07 15:25 ` Michael J Gruber
2010-12-07 16:25 ` Nguyen Thai Ngoc Duy
2010-12-07 16:22 ` Jakub Narebski
2010-12-07 16:26 ` Nguyen Thai Ngoc Duy
2010-12-07 17:06 ` Jeff King
2010-12-07 18:14 ` Shawn Pearce
2010-12-07 18:20 ` Jeff King
2010-12-07 18:23 ` Shawn O. Pearce
2010-12-07 18:35 ` Jeff King
2010-12-07 18:37 ` Shawn O. Pearce [this message]
2010-12-07 18:39 ` Jeff King
2010-12-07 18:41 ` Shawn O. Pearce
2010-12-07 19:21 ` Junio C Hamano
2010-12-07 19:38 ` Jeff King
2010-12-07 16:23 ` Casey Dahlin
2010-12-07 17:45 ` Jonathan Nieder
2010-12-07 17:54 ` Casey Dahlin
2010-12-07 18:02 ` Jonathan Nieder
2010-12-07 18:26 ` Casey Dahlin
2010-12-07 20:25 ` Junio C Hamano
2010-12-07 20:55 ` Jonathan Nieder
2010-12-07 18:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207183739.GB3725@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).