From: Jonathan Nieder <jrnieder@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Arnout Engelen <arnouten@bzzt.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Improved error messages when temporary file creation fails
Date: Tue, 7 Dec 2010 18:12:36 -0600 [thread overview]
Message-ID: <20101208001236.GA25527@burratino> (raw)
In-Reply-To: <idmhjl$n1j$1@dough.gmane.org>
Jakub Narebski wrote:
> Arnout Engelen wrote:
>> On Tue, Dec 07, 2010 at 12:56:17PM -0800, Junio C Hamano wrote:
>>>> + char origtemplate[255];
>>>> + strlcpy(origtemplate, template, 255);
>>>
>>> Why "255"?
[...]
> Why not use PATH_MAX instead of 255?
The advantage I can see to 256 is a small speed-up in the "no errors"
code path. Since the I/O would tend to be much more costly and PATH_MAX
is self explanatory, using PATH_MAX does seem cleaner.
I know you all are aware of this already; just thought I'd mention it
while forwarding the original message to Arnout. :)
Jonathan
next prev parent reply other threads:[~2010-12-08 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 18:16 [PATCH] Improved error messages when temporary file creation fails Arnout Engelen
2010-12-07 19:09 ` Jonathan Nieder
2010-12-07 20:56 ` Junio C Hamano
2010-12-07 21:20 ` Arnout Engelen
2010-12-07 23:56 ` Jakub Narebski
2010-12-08 0:12 ` Jonathan Nieder [this message]
2010-12-08 2:01 ` Junio C Hamano
2010-12-18 16:55 ` Arnout Engelen
2010-12-18 20:05 ` Jonathan Nieder
2010-12-18 20:47 ` Junio C Hamano
2010-12-18 20:47 ` Junio C Hamano
2010-12-18 21:28 ` Arnout Engelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208001236.GA25527@burratino \
--to=jrnieder@gmail.com \
--cc=arnouten@bzzt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).