From: Johannes Sixt <j6t@kdbg.org>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Junio C Hamano <gitster@pobox.com>,
"GIT Mailing-list" <git@vger.kernel.org>,
patthoyts@gmail.com, pharris@opentext.com
Subject: Re: [PATCH 04/14] msvc: Fix macro redefinition warnings
Date: Wed, 8 Dec 2010 20:51:46 +0100 [thread overview]
Message-ID: <201012082051.46644.j6t@kdbg.org> (raw)
In-Reply-To: <AANLkTimpj31CSzaxH4ZuYdADvtV4KSwfk04eGSRYSLFH@mail.gmail.com>
On Mittwoch, 8. Dezember 2010, Sebastian Schuberth wrote:
> Indeed, I remember that back then my
> msysgit working tree did not compile with MSVC if I didn't have these
> defines (and I vaguely remember that this was caused by MSVC using
> different a header file than MinGW, or in a different order, or
> something similar).
...
> After defining LF_FACESIZE and TMPF_TRUETYPE in winansi.c, and
> INTMAX_MAX in git-compat-util.h, I was also able to compile the
> v1.7.3.2.msysgit.0 tag with MSVC. If I revert 4091bfc on top of it, it
> still compiles fine for me.
>
> > So, once again, I see no reason to keep them ... Unless you know
> > otherwise.
>
> I agree to remove the lines and vote in favor of Ramsay's patch. Feel
> free to add me as Signed-off-by or Acked-by.
Under these circumstances, I agree as well with Ramsay's patch.
-- Hannes
prev parent reply other threads:[~2010-12-08 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 19:00 [PATCH 04/14] msvc: Fix macro redefinition warnings Ramsay Jones
2010-12-04 21:04 ` Johannes Sixt
2010-12-08 0:05 ` Ramsay Jones
2010-12-08 10:32 ` Sebastian Schuberth
2010-12-08 19:51 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012082051.46644.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@gmail.com \
--cc=pharris@opentext.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).