From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Subject: [PATCH] transport-helper: avoid dependency on thread-utils.h
Date: Fri, 10 Dec 2010 05:48:39 -0600 [thread overview]
Message-ID: <20101210114839.GA5771@burratino> (raw)
Since the transport-helper does not use recursive mutexes or ask the
number of cores, it does not require any declarations from the
thread-utils lib. Removing the unnecessary #include avoids false
positives from "make CHECK_HEADER_DEPENDENCIES=1".
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
The #include directive in question was added in 7851b1e60
(remote-fd/ext: finishing touches after code review, 2010-11-17),
at the same times as the necessary #include for <pthread.h>.
This patch seems to work for me, but I wouldn't be surprised if
to be missing something.
transport-helper.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 3a50856..7c99051 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -11,7 +11,6 @@
#ifndef NO_PTHREADS
#include <pthread.h>
-#include "thread-utils.h"
#endif
static int debug;
--
1.7.2.4
next reply other threads:[~2010-12-10 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 11:48 Jonathan Nieder [this message]
2010-12-10 18:21 ` [PATCH] transport-helper: avoid dependency on thread-utils.h Junio C Hamano
2010-12-10 19:46 ` [PATCH 0/2] " Jonathan Nieder
2010-12-10 19:47 ` [PATCH 1/2] simplify inclusion of pthread.h Jonathan Nieder
2010-12-10 19:51 ` Jonathan Nieder
2010-12-10 19:48 ` [PATCH 2/2] Makefile: transport-helper uses thread-utils.h Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210114839.GA5771@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).