git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gitk: Prevent the text pane from becoming editable
@ 2010-11-14 12:21 Stefan Haller
  2010-12-12  4:24 ` Paul Mackerras
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Haller @ 2010-11-14 12:21 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: git

From: Stefan Haller <stefan@haller-berlin.de>

When setting the "Patch/Tree" radio buttons to "Tree" and
clicking on a file to display it, the text pane would
accidentally become editable (because of the early return
in getblobline).

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 45e3380..260be1b 100755
--- a/gitk
+++ b/gitk
@@ -7303,6 +7303,7 @@ proc getblobline {bf id} {
 			    [lindex [split $commentend .] 0]}]
 	    mark_ctext_line $lnum
 	}
+	$ctext config -state disabled
 	return 0
     }
     $ctext config -state disabled
-- 
1.7.3.2.154.gcfae0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gitk: Prevent the text pane from becoming editable
  2010-11-14 12:21 [PATCH] gitk: Prevent the text pane from becoming editable Stefan Haller
@ 2010-12-12  4:24 ` Paul Mackerras
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2010-12-12  4:24 UTC (permalink / raw)
  To: Stefan Haller; +Cc: git

On Sun, Nov 14, 2010 at 01:21:50PM +0100, Stefan Haller wrote:
> From: Stefan Haller <stefan@haller-berlin.de>
> 
> When setting the "Patch/Tree" radio buttons to "Tree" and
> clicking on a file to display it, the text pane would
> accidentally become editable (because of the early return
> in getblobline).

Thanks, applied.

Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-12  4:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-14 12:21 [PATCH] gitk: Prevent the text pane from becoming editable Stefan Haller
2010-12-12  4:24 ` Paul Mackerras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).