From: Thomas Rast <trast@student.ethz.ch>
To: Jan Wielemaker <J.Wielemaker@cs.vu.nl>
Cc: <git@vger.kernel.org>
Subject: Re: subdirectory-filter does not delete files before the directory came into existence?
Date: Sun, 19 Dec 2010 23:51:48 +0100 [thread overview]
Message-ID: <201012192351.49279.trast@student.ethz.ch> (raw)
In-Reply-To: <1292751289.21229.26.camel@ct>
Jan Wielemaker wrote:
> On Sun, 2010-12-19 at 03:23 +0100, Thomas Rast wrote:
> > Jan Wielemaker wrote:
> > > * get all tags, use comm and delete the tags not in the `contained'
> > > set above.
[...]
> > http://article.gmane.org/gmane.comp.version-control.git/91708
[...]
> Funny. That was me having problems with filtering out directories
> as well :-) I thought your patch was added using the --prune-empty
> flag. I guess you can comment on that. I can confirm that I've got
> nice and clean filtering using
No, those two are rather different. --prune-empty drops commits that
became "no-ops" in the sense that their tree is the same as their
(only) parent's. In the case of --subdirectory-filter, --prune-empty
is most likely[*] redundant since the former already enables history
simplification limited to that directory.
As you can see from "TOY PATCH", my patch wasn't really meant for
application anyway. I'm now wondering what the ramifications would
be. filter-branch only attempts to change refs that you told it to
(listed positively on the command line), so maybe deleting anything
that was not rewritten is a sensible option (not default, mind you).
[*] Read: I think it is redundant, I'm just too lazy to double-check.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2010-12-19 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 22:21 subdirectory-filter does not delete files before the directory came into existence? Jan Wielemaker
2010-12-14 23:03 ` Thomas Rast
2010-12-15 9:50 ` Jan Wielemaker
2010-12-15 10:40 ` Jan Wielemaker
2010-12-15 12:22 ` Jan Wielemaker
2010-12-19 2:23 ` Thomas Rast
2010-12-19 9:34 ` Jan Wielemaker
2010-12-19 22:51 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012192351.49279.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=J.Wielemaker@cs.vu.nl \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).