From: Jeff King <peff@peff.net>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] completion: add missing configuration variables
Date: Mon, 20 Dec 2010 16:20:18 -0500 [thread overview]
Message-ID: <20101220212018.GA18503@sigill.intra.peff.net> (raw)
In-Reply-To: <1292858305-7679-1-git-send-email-martin.von.zweigbergk@gmail.com>
On Mon, Dec 20, 2010 at 04:18:25PM +0100, Martin von Zweigbergk wrote:
> Quite a few configuration variables have been added since 226b343
> (completion: add missing configuration variables to _git_config(),
> 2009-05-03). Add these variables to the Bash completion script.
>
> Also remove the obsolete 'add.ignore-errors' and
> 'color.grep.external', as well as 'diff.renameLimit.', which never
> existed and rename the misspelled 'sendemail.aliasesfiletype'.
>
> Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
> ---
> Changes since previous version:
>
> Removed 'add.ignore-errors' and 'color.grep.external'.
>
> Added 'fetch.recurseSubmodules', which has entered master since last
> round.
>
> (Still based on master.)
Based on our prior discussion, I think this can go in, and all of the
other issues can be left for future patches if somebody wants to address
them.
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2010-12-20 21:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 6:46 [PATCH] completion: add missing configuration variables Martin von Zweigbergk
2010-12-15 13:00 ` Jeff King
2010-12-15 19:44 ` Martin von Zweigbergk
2010-12-16 4:23 ` Jeff King
2010-12-17 20:52 ` Junio C Hamano
2010-12-17 21:04 ` Jeff King
2010-12-16 12:42 ` SZEDER Gábor
2010-12-16 7:14 ` Martin von Zweigbergk
2010-12-16 14:28 ` Jeff King
2010-12-17 20:44 ` Junio C Hamano
2010-12-17 21:21 ` Jeff King
2010-12-20 15:18 ` [PATCH v2] " Martin von Zweigbergk
2010-12-20 21:20 ` Jeff King [this message]
2010-12-21 1:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220212018.GA18503@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).