git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: strk <strk@keybit.net>
To: git@vger.kernel.org
Subject: Re: git-svn author file and svn2cl compatibility
Date: Thu, 23 Dec 2010 09:11:20 +0100	[thread overview]
Message-ID: <20101223081120.GA60001@keybit.net> (raw)
In-Reply-To: <20101222184110.GA53847@keybit.net>

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

I attach a patch implementing the added support.

--strk;

On Wed, Dec 22, 2010 at 07:41:10PM +0100, strk wrote:
> The svn2cl tool [1] supports an author file to use for
> generating the ChangeLog.
> 
> [1] http://arthurdejong.org/svn2cl/
> 
> Format of the file is:
>  nick1:Name <email>
>  nick2:Name 2 <email2>
> 
> It would be nice if git-svn could support the same format
> in addition to the one using ``='' instead of ``:''.
> 
> That way you might have the authors file already available
> in projects that made use of svn2cl.
> 
> Does it make sense ?
> 
> Please include me in reply as I'm not subscribed.

[-- Attachment #2: 0001-Also-accept-svn2cl-format-for-authors-file.patch --]
[-- Type: text/plain, Size: 758 bytes --]

>From 0e6d6f3415b6d206e9cd8001ed4ce994e4150c39 Mon Sep 17 00:00:00 2001
From: Sandro Santilli <strk@keybit.net>
Date: Thu, 23 Dec 2010 09:07:10 +0100
Subject: [PATCH] Also accept svn2cl format for authors file

---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 177dd25..6fd0f7f 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1424,7 +1424,7 @@ sub load_authors {
 	my $log = $cmd eq 'log';
 	while (<$authors>) {
 		chomp;
-		next unless /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
+		next unless /^(.+?|\(no author\))\s*[=:]\s*(.+?)\s*<(.+)>\s*$/;
 		my ($user, $name, $email) = ($1, $2, $3);
 		if ($log) {
 			$Git::SVN::Log::rusers{"$name <$email>"} = $user;
-- 
1.7.0.4


      reply	other threads:[~2010-12-23  8:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 18:41 git-svn author file and svn2cl compatibility strk
2010-12-23  8:11 ` strk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101223081120.GA60001@keybit.net \
    --to=strk@keybit.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).