From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Mihai Rusu <dizzy@google.com>, <git@vger.kernel.org>
Subject: Re: Possible bug in "git rebase" (non-interactive) with regards to post-rewrite
Date: Sun, 26 Dec 2010 11:38:20 +0100 [thread overview]
Message-ID: <201012261138.21059.trast@student.ethz.ch> (raw)
In-Reply-To: <7vd3ot48ke.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> When "rebase --skip" is used to skip the last patch in the series, the
> code to wrap up the rewrite by copying the notes from old to new commits
> and also by running the post-rewrite hook was bypassed.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
[...]
> -if test "$this" -gt "$last"
> -then
> - say Nothing to do.
> - rm -fr "$dotest"
> - exit
> -fi
> -
> while test "$this" -le "$last"
> do
> msgnum=`printf "%0${prec}d" $this`
Ack, thanks for patching this.
(I think it's saner anyway not to say "nothing to do" when the user
would expect "we're all done here"...)
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2010-12-26 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 22:39 Possible bug in "git rebase" (non-interactive) with regards to post-rewrite Mihai Rusu
2010-12-23 0:02 ` Junio C Hamano
2010-12-23 0:49 ` Junio C Hamano
2010-12-26 10:38 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012261138.21059.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=dizzy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).