From: Jonathan Nieder <jrnieder@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, John 'Warthog9' Hawley <warthog9@kernel.org>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/2] gitweb: make logo optional
Date: Tue, 4 Jan 2011 10:29:18 -0600 [thread overview]
Message-ID: <20110104162918.GA30141@burratino> (raw)
In-Reply-To: <201101041252.40254.jnareb@gmail.com>
Jakub Narebski wrote:
> On Tue, 4 Dec 2011, Jonathan Nieder wrote:
>> Some sites may not want to have a logo at all. In particular, git
>> instaweb can benefit from this.
>
> Why do you think that git-instaweb can benefit from not having logo?
> You need gitweb.css anyway, so it is not much more trouble to serve
> additional static file, git-logo.png.
Yep, that sentence is stale (it only applied in 1.7.1.x days) and
should have been removed.
> corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;
> IIRC gitweb requires something later than 5.8.0 for good support of
> Unicode (Encode module).
>
>>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>
> For what it is worth it:
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
Thanks for looking it over.
next prev parent reply other threads:[~2011-01-04 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 5:02 [PATCH 0/2] gitweb: make logo optional Jonathan Nieder
2011-01-04 5:02 ` [PATCH 1/2] gitweb: skip logo in atom feed when there is none Jonathan Nieder
2011-01-05 0:25 ` Jakub Narebski
2011-01-05 0:45 ` Junio C Hamano
2011-01-04 5:05 ` [PATCH 2/2] gitweb: make logo optional Jonathan Nieder
2011-01-04 11:52 ` Jakub Narebski
2011-01-04 16:29 ` Jonathan Nieder [this message]
2011-01-04 23:24 ` [PATCH 0/2] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104162918.GA30141@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).