From: Jonathan Nieder <jrnieder@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Vallon, Justin" <Justin.Vallon@deshaw.com>,
"Robin H. Johnson" <robbat2@gentoo.org>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] Fix false positives in t3404 due to SHELL=/bin/false
Date: Tue, 4 Jan 2011 16:58:26 -0600 [thread overview]
Message-ID: <20110104225826.GA2122@burratino> (raw)
In-Reply-To: <vpqhbdoxpzp.fsf@bauges.imag.fr>
Matthieu Moy wrote:
> "Vallon, Justin" <Justin.Vallon@deshaw.com> writes:
>> --- a/t/t3404-rebase-interactive.sh
>> +++ b/t/t3404-rebase-interactive.sh
>> @@ -71,8 +71,9 @@ test_expect_success 'setup' '
>> # "exec" commands are ran with the user shell by default, but this may
>> # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
>> # to create a file. Unseting SHELL avoids such non-portable behavior
>> -# in tests.
>> +# in tests. It must be exported for it to take effect where needed.
>> SHELL=
>> +export SHELL
>
> (my bad, I wrote this SHELL= without exporting it. Since bash
> re-exports already exported variables when they are assigned, and my
> /bin/sh points to bash, I didn't notice)
Isn't that how export works in all Bourne-style shells? For example:
$ env var=outside dash -c '
var=inside;
dash -c "echo \$var"
'
inside
$
Maybe in the failing case SHELL was not exported but just set to
/bin/false in .bashrc or similar?
next prev parent reply other threads:[~2011-01-04 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 2:50 [PATCH] Fix false positives in t3404 due to SHELL=/bin/false Robin H. Johnson
2010-12-27 6:10 ` Junio C Hamano
2010-12-27 8:03 ` [PATCH v2] " Robin H. Johnson
2010-12-28 19:58 ` Junio C Hamano
2011-01-04 14:43 ` Vallon, Justin
2011-01-04 20:35 ` Robin H. Johnson
2011-01-04 22:28 ` Matthieu Moy
2011-01-04 22:58 ` Jonathan Nieder [this message]
2011-01-04 23:39 ` Junio C Hamano
2011-01-05 15:04 ` Vallon, Justin
2011-01-05 18:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104225826.GA2122@burratino \
--to=jrnieder@gmail.com \
--cc=Justin.Vallon@deshaw.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).