git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Alexander Gladysh <agladysh@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: False positives in git diff-index
Date: Wed, 5 Jan 2011 01:15:15 -0500	[thread overview]
Message-ID: <20110105061515.GA12163@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTimQCMr+emw=rXdBKKnD_W9G981zCkboKgiDWxPF@mail.gmail.com>

On Wed, Jan 05, 2011 at 06:07:35AM +0000, Alexander Gladysh wrote:

> > Basically, we generate random data which has a 20% chance of
> > being the same as what's there. When it is, we should get "not bothering
> > to commit", but in your error case, we would try to commit (and get "no
> > changes").
> 
> > But using that script, I can't replicate your problem. Can you try
> > running it on the same box you're having trouble with? That might at
> > least tell us if it's your environment or something more complex going
> > on.
> 
> Thank you. I tried it, and, unfortunately, it does not reproduce the
> problem.

Oh well, thanks for trying.

Going back to your original reproduction recipe, can you change the
"diff-index" line to actually report on what it thinks is different?
That is, drop the "--quiet" and have it actually produce a patch?

It would be interesting to see what is different, and how that compares
with the "git status" you run just prior to it (and whether it matches
the file you "git add"ed just above).

You haven't told us much about your build process. Are you absolutely
sure that there couldn't be another process on the system manipulating
the files between the various runs?

Are you running on top of any special filesystem that might not meet the
consistency guarantees we expect (though in that case, I would assume my
trivial script would have reproduced).

-Peff

  reply	other threads:[~2011-01-05  6:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27  8:49 False positives in git diff-index Alexander Gladysh
2011-01-04  9:45 ` Alexander Gladysh
2011-01-04 11:47   ` Zenaan Harkness
2011-01-04 12:01     ` Alexander Gladysh
2011-01-04 14:08       ` Jakub Narebski
2011-01-04 14:46         ` Alexander Gladysh
2011-01-05  5:48   ` Jeff King
2011-01-05  6:07     ` Alexander Gladysh
2011-01-05  6:15       ` Jeff King [this message]
2011-01-05  7:46         ` Alexander Gladysh
2011-01-05  8:08           ` Jeff King
2011-01-06 12:12             ` Alexander Gladysh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105061515.GA12163@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=agladysh@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).