git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, j6t@kdbg.org
Subject: Re: [PATCH v2] alias: use run_command api to execute aliases
Date: Thu, 6 Jan 2011 14:05:18 -0600	[thread overview]
Message-ID: <20110106200518.GA14945@burratino> (raw)
In-Reply-To: <1294343649-6272-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund wrote:

> --- a/git.c
> +++ b/git.c
> @@ -177,22 +177,22 @@ static int handle_alias(int *argcp, const char ***argv)
[...]
> +			alias_argv = xmalloc(sizeof(char *) * argc + 1);

Missed a spot?  (missing parens)

Thanks for this.  It also should provide a minor speedup in the case
of commands with no shell metacharacters.

  reply	other threads:[~2011-01-06 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 19:54 [PATCH v2] alias: use run_command api to execute aliases Erik Faye-Lund
2011-01-06 20:05 ` Jonathan Nieder [this message]
2011-01-06 20:14   ` Erik Faye-Lund
2011-01-06 20:27 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106200518.GA14945@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=kusmabite@gmail.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).