From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Anders Kaseorg <andersk@MIT.EDU>,
git@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] Mark gitk script executable
Date: Thu, 6 Jan 2011 21:01:19 -0600 [thread overview]
Message-ID: <20110107030119.GA32290@burratino> (raw)
In-Reply-To: <7vlj2x8mr4.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Anders Kaseorg <andersk@MIT.EDU> writes:
>> The executable bit on gitk-git/gitk was lost (accidentally it seems) by
>> commit 62ba5143ec2ab9d4083669b1b1679355e7639cd5. Put it back, so that
>> gitk can be run directly from a git.git checkout.
>>
>> Note that the script is already executable in gitk.git, just not in
>> git.git.
>
> It did not lose the bit by accident but 62ba5143 pretty much was a
> deliberate fix. "gitk" is a source file, and its build product,
> gitk-wish, is what is eventually installed with executable bit on.
How does this case differ from other executable source files like
git-am.sh?
next prev parent reply other threads:[~2011-01-07 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 1:14 [PATCH] Mark gitk script executable Anders Kaseorg
2011-01-07 2:34 ` Junio C Hamano
2011-01-07 3:01 ` Jonathan Nieder [this message]
2011-01-07 19:29 ` Junio C Hamano
2011-01-07 20:35 ` Anders Kaseorg
2011-01-07 20:45 ` Junio C Hamano
2011-01-07 20:56 ` Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107030119.GA32290@burratino \
--to=jrnieder@gmail.com \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).