From: Jonathan Nieder <jrnieder@gmail.com>
To: "Robin H. Johnson" <robbat2@gentoo.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-cvs*: Make building (and testing) of CVS interface scripts optionally selectable
Date: Fri, 7 Jan 2011 16:01:48 -0600 [thread overview]
Message-ID: <20110107220147.GB9194@burratino> (raw)
In-Reply-To: <1294433290-9262-1-git-send-email-robbat2@gentoo.org>
Robin H. Johnson wrote:
> Presently, the CVS interface scripts are always built, and their
> test-suites run based on a binary named 'cvs' happening to return zero.
> If there something other than the real CVS there, bad things happened
> during the test-suite run.
This explanation seems quite odd to me. Are you saying we can't rely
on the 'cvs' name being "taken" and should live in fear that someone
will implement an incompatible utility with the same name? Did that
actually happen?
I would find it easier to believe
Building and testing git's cvs support is slow, because ...
So give users with no interest in cvs interoperability a way
out. By defining NO_CVS you can avoid this time-consuming
piece of the build process.
Or for a different patch:
Add a NO_CVS knob so users with no interest in cvs support
can avoid polluting their $(libexecdir) with unwanted entries.
Or:
Introduce a new NO_CVS knob. If set, the CVS interop scripts
will be replaced by unimplemented.sh so sysadmins and
distributors can hopefully get a nice, clear error report instead
of confusion when users try to run them with cvs not installed.
next prev parent reply other threads:[~2011-01-07 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:48 [PATCH] git-cvs*: Make building (and testing) of CVS interface scripts optionally selectable Robin H. Johnson
2011-01-07 22:01 ` Jonathan Nieder [this message]
2011-01-07 22:55 ` Robin H. Johnson
2011-01-07 23:50 ` Junio C Hamano
2011-01-07 22:05 ` Junio C Hamano
2011-01-07 22:53 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107220147.GB9194@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).