From: Johan Herland <johan@herland.net>
To: Jeenu V <jeenuv@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git notes and core.editor config
Date: Tue, 11 Jan 2011 11:31:17 +0100 [thread overview]
Message-ID: <201101111131.17429.johan@herland.net> (raw)
In-Reply-To: <AANLkTi=0BrBV+DLF_QfDi0mMVdz5tCLFsDMBKvw52nzz@mail.gmail.com>
On Tuesday 11 January 2011, Jeenu V wrote:
> My core.editor value in $HOME/.gitconfig is set to
>
> [core]
> editor = vi "+set tw=72 spell"
>
> so that I've text width of 72 with spell check turned on. I haven't
> found problems with any git commands that invoke editor, but notes.
> 'git notes' seems to invoke the vi for me with 3 separate arguments
> instead of just one: "+set, tw=72, and spell". In other words, I
> don't think it honors shell quoting for editor config variable.
>
> Could this be a bug?
Indeed, it could, but I cannot immediately see what causes it. In
current 'master', builtin/notes.c launches the editor like this:
if (launch_editor(path, &(msg->buf), NULL)) ...
while builtin/commit.c lauches the editor like this:
if (launch_editor(git_path(commit_editmsg), NULL, env)) ...
In both cases, the details of interpreting core.editor is left to
git_default_core_config(), and passed to launch_editor() using the
editor_program global variable. AFAICS there is no difference between
how "notes" and "commit" interprets core.editor.
What Git version are you running?
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2011-01-11 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 10:11 git notes and core.editor config Jeenu V
2011-01-11 10:31 ` Johan Herland [this message]
2011-01-11 11:14 ` Jeenu V
2011-01-11 12:26 ` Thomas Rast
2011-01-11 12:36 ` Johan Herland
2011-01-11 13:12 ` Jeenu V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101111131.17429.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=jeenuv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).