From: Johan Herland <johan@herland.net>
To: Jeenu V <jeenuv@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git notes and core.editor config
Date: Tue, 11 Jan 2011 13:36:19 +0100 [thread overview]
Message-ID: <201101111336.19466.johan@herland.net> (raw)
In-Reply-To: <AANLkTik-=s-F8dmBRLU8o9LcSztb1P0WnkN5HK_n_No4@mail.gmail.com>
On Tuesday 11 January 2011, Jeenu V wrote:
> On Tue, Jan 11, 2011 at 4:01 PM, Johan Herland <johan@herland.net>
wrote:
> > On Tuesday 11 January 2011, Jeenu V wrote:
> >> My core.editor value in $HOME/.gitconfig is set to
> >>
> >> [core]
> >> editor = vi "+set tw=72 spell"
> >>
> >> so that I've text width of 72 with spell check turned on. I
> >> haven't found problems with any git commands that invoke editor,
> >> but notes. 'git notes' seems to invoke the vi for me with 3
> >> separate arguments instead of just one: "+set, tw=72, and spell".
> >> In other words, I don't think it honors shell quoting for editor
> >> config variable.
> >>
> >> Could this be a bug?
> >
> > What Git version are you running?
>
> $ git --version
> git version 1.7.0.4
Ah, there's your problem. In v1.7.1 "git notes" was builtin-ified (it
used to be a shell script, but was reimplemented in C), so you're still
running the shell script version of "git notes". I believe upgrading
will solve your problem (as well as making "git notes" more
featureful).
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2011-01-11 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 10:11 git notes and core.editor config Jeenu V
2011-01-11 10:31 ` Johan Herland
2011-01-11 11:14 ` Jeenu V
2011-01-11 12:26 ` Thomas Rast
2011-01-11 12:36 ` Johan Herland [this message]
2011-01-11 13:12 ` Jeenu V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101111336.19466.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=jeenuv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).