From: Thomas Rast <trast@student.ethz.ch>
To: Jonathan Nieder <jrnieder@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Stephen Kelly <steveire@gmail.com>,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH v2] Introduce new configuation option to override committer information
Date: Tue, 11 Jan 2011 15:42:14 +0100 [thread overview]
Message-ID: <201101111542.15185.trast@student.ethz.ch> (raw)
In-Reply-To: <20110109172431.GA7718@burratino>
Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>
> > The 'user.name' and 'user.email' configuration
> > options set both author and committer information. To solve this,
> > introduce 'user.committername' and 'user.committeremail' configuration
> > options to override committer name and email respectively.
>
> Predictably, I don't like this idea at all. How would we explain this
> to a new user that is reading over gitconfig(5) for the first time?
> It makes the semantics of the committer and author name (that are mostly
> meant for giving credit and a contact address) much more murky.
Well, now that I'm rethinking it, the weird thing is that it does not
override in the way that the user intuitively might expect.
Assume we also had user.authoremail for completeness, and you do
git config --global user.authoremail author@example.com
git config --global user.committeremail committer@example.com
git config user.email user@example.com
Probably the user would expect this to result in a uniform
user@example.com identity for the current repo, but I don't think we
can twist it that way with the current config infrastructure. The
obvious option of having user.{author,committer}* override the more
generic user.* would be contrary to that intuition.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-01-11 14:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 13:16 Wish: make commiter email address configurable per-repo Stephen Kelly
2011-01-07 13:20 ` Thomas Rast
2011-01-07 13:23 ` Stephen Kelly
2011-01-07 13:43 ` Thomas Rast
2011-01-07 18:01 ` Stephen Kelly
2011-01-07 18:19 ` Erik Faye-Lund
2011-01-20 18:44 ` Junio C Hamano
2011-01-08 8:03 ` [PATCH] Introduce new configuation option to override committer information Ramkumar Ramachandra
2011-01-08 19:24 ` Stephen Kelly
2011-01-09 10:29 ` [PATCH v2] " Ramkumar Ramachandra
2011-01-09 17:24 ` Jonathan Nieder
2011-01-11 13:41 ` Stephen Kelly
2011-01-11 14:19 ` Ramkumar Ramachandra
2011-01-11 14:42 ` Thomas Rast [this message]
2011-01-20 19:00 ` Junio C Hamano
2011-01-20 11:16 ` Stephen Kelly
2011-01-20 12:52 ` Thomas Rast
2011-01-20 15:24 ` Stephen Kelly
2011-01-20 19:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101111542.15185.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=kusmabite@gmail.com \
--cc=steveire@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).