From: Jonathan Nieder <jrnieder@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
Scott Johnson <scottj75074@yahoo.com>,
Michael J Gruber <git@drmicha.warpmail.net>,
Matthijs Kooijman <matthijs@stdin.nl>,
git@vger.kernel.org
Subject: [RFC/PATCH 0/3] Re: t4034: bulk verify builtin word regex sanity
Date: Tue, 11 Jan 2011 15:47:07 -0600 [thread overview]
Message-ID: <20110111214707.GA29133@burratino> (raw)
In-Reply-To: <854c8b6fa8a368bb34cc22d3fc948ae7136ed177.1292688058.git.trast@student.ethz.ch>
Thomas Rast wrote:
> The builtin word regexes should be tested with some simple examples
> against simple issues, like failing to match a non-space character.
> Do this in bulk.
The above patch depends on "diff.c: implement a sanity check for word
regexes" but not in any essential way. Patch 1 below is the part that
is still relevant without it.
Patch 2 changes the UTF-8 catchall to match a single non-ASCII
character[1], at the same time as making it harder to forget to use.
(My motivation is that the UTF-8 catchall is missing in the new perl
support.)
Patch 3 contains some cosmetic tweaks to the tests. They were meant
as preparations for patch 2 but I checkened out and stopped there.
Thoughts and improvements welcome, as always.
Jonathan Nieder (2):
userdiff: simplify word-diff safeguard
t4034 (diff --word-diff): style suggestions
Thomas Rast (1):
t4034: bulk verify builtin word regex sanity
t/t4034-diff-words.sh | 463 +++++++++++++++++++++++-------------------------
t/t4034/bibtex/expect | 15 ++
t/t4034/bibtex/post | 10 +
t/t4034/bibtex/pre | 9 +
t/t4034/cpp/expect | 36 ++++
t/t4034/cpp/post | 19 ++
t/t4034/cpp/pre | 19 ++
t/t4034/csharp/expect | 35 ++++
t/t4034/csharp/post | 18 ++
t/t4034/csharp/pre | 18 ++
t/t4034/fortran/expect | 10 +
t/t4034/fortran/post | 5 +
t/t4034/fortran/pre | 5 +
t/t4034/html/expect | 8 +
t/t4034/html/post | 3 +
t/t4034/html/pre | 3 +
t/t4034/java/expect | 36 ++++
t/t4034/java/post | 19 ++
t/t4034/java/pre | 19 ++
t/t4034/objc/expect | 35 ++++
t/t4034/objc/post | 18 ++
t/t4034/objc/pre | 18 ++
t/t4034/pascal/expect | 35 ++++
t/t4034/pascal/post | 18 ++
t/t4034/pascal/pre | 18 ++
t/t4034/php/expect | 35 ++++
t/t4034/php/post | 18 ++
t/t4034/php/pre | 18 ++
t/t4034/python/expect | 34 ++++
t/t4034/python/post | 17 ++
t/t4034/python/pre | 17 ++
t/t4034/ruby/expect | 34 ++++
t/t4034/ruby/post | 17 ++
t/t4034/ruby/pre | 17 ++
t/t4034/tex/expect | 9 +
t/t4034/tex/post | 4 +
t/t4034/tex/pre | 4 +
userdiff.c | 37 ++---
38 files changed, 887 insertions(+), 266 deletions(-)
create mode 100644 t/t4034/bibtex/expect
create mode 100644 t/t4034/bibtex/post
create mode 100644 t/t4034/bibtex/pre
create mode 100644 t/t4034/cpp/expect
create mode 100644 t/t4034/cpp/post
create mode 100644 t/t4034/cpp/pre
create mode 100644 t/t4034/csharp/expect
create mode 100644 t/t4034/csharp/post
create mode 100644 t/t4034/csharp/pre
create mode 100644 t/t4034/fortran/expect
create mode 100644 t/t4034/fortran/post
create mode 100644 t/t4034/fortran/pre
create mode 100644 t/t4034/html/expect
create mode 100644 t/t4034/html/post
create mode 100644 t/t4034/html/pre
create mode 100644 t/t4034/java/expect
create mode 100644 t/t4034/java/post
create mode 100644 t/t4034/java/pre
create mode 100644 t/t4034/objc/expect
create mode 100644 t/t4034/objc/post
create mode 100644 t/t4034/objc/pre
create mode 100644 t/t4034/pascal/expect
create mode 100644 t/t4034/pascal/post
create mode 100644 t/t4034/pascal/pre
create mode 100644 t/t4034/php/expect
create mode 100644 t/t4034/php/post
create mode 100644 t/t4034/php/pre
create mode 100644 t/t4034/python/expect
create mode 100644 t/t4034/python/post
create mode 100644 t/t4034/python/pre
create mode 100644 t/t4034/ruby/expect
create mode 100644 t/t4034/ruby/post
create mode 100644 t/t4034/ruby/pre
create mode 100644 t/t4034/tex/expect
create mode 100644 t/t4034/tex/post
create mode 100644 t/t4034/tex/pre
[1] suggested in <201012261206.11942.trast@student.ethz.ch>, which is
missing from gmane for some reason.
next prev parent reply other threads:[~2011-01-11 21:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 3:47 html userdiff is not showing all my changes Scott Johnson
2010-12-15 9:06 ` Michael J Gruber
2010-12-15 9:12 ` Matthijs Kooijman
2010-12-15 9:29 ` Michael J Gruber
2010-12-15 15:13 ` [PATCH 0/4] --word-regex sanity checking and such Thomas Rast
2010-12-15 15:13 ` [PATCH 1/4] diff.c: pass struct diff_words into find_word_boundaries Thomas Rast
2010-12-15 15:13 ` [PATCH 2/4] diff.c: implement a sanity check for word regexes Thomas Rast
2010-12-15 15:13 ` [PATCH 3/4] userdiff: fix typo in ruby word regex Thomas Rast
2010-12-15 15:13 ` [PATCH 4/4] t4034: bulk verify builtin word regex sanity Thomas Rast
[not found] ` <913156.57703.qm@web110711.mail.gq1.yahoo.com>
2010-12-15 19:51 ` [PATCH 0/4] --word-regex sanity checking and such Thomas Rast
2010-12-15 20:48 ` Scott Johnson
2010-12-18 16:17 ` [PATCH v2 " Thomas Rast
2010-12-18 16:17 ` [PATCH v2 1/4] diff.c: pass struct diff_words into find_word_boundaries Thomas Rast
2010-12-18 16:17 ` [PATCH v2 2/4] diff.c: implement a sanity check for word regexes Thomas Rast
2010-12-18 21:00 ` Junio C Hamano
2010-12-19 1:59 ` Thomas Rast
2010-12-18 16:17 ` [PATCH v2 3/4] userdiff: fix typo in ruby and python " Thomas Rast
2010-12-18 21:02 ` Junio C Hamano
2010-12-19 2:10 ` Thomas Rast
2010-12-18 16:17 ` [PATCH v2 4/4] t4034: bulk verify builtin word regex sanity Thomas Rast
2011-01-11 21:47 ` Jonathan Nieder [this message]
2011-01-11 21:48 ` [PATCH 1/3] " Jonathan Nieder
2011-01-18 18:00 ` Re*: " Junio C Hamano
2011-01-11 21:48 ` [PATCH 2/3] userdiff: simplify word-diff safeguard Jonathan Nieder
2011-01-11 21:49 ` [PATCH 3/3] t4034 (diff --word-diff): style suggestions Jonathan Nieder
2010-12-18 16:24 ` [PATCH v2 0/4] --word-regex sanity checking and such Thomas Rast
2010-12-18 20:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111214707.GA29133@burratino \
--to=jrnieder@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthijs@stdin.nl \
--cc=scottj75074@yahoo.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).