git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: JT Olds <jtolds@xnet5.com>
Cc: git@vger.kernel.org
Subject: Re: Git Rebase blows away GIT_AUTHOR_NAME
Date: Thu, 13 Jan 2011 13:47:39 -0500	[thread overview]
Message-ID: <20110113184739.GA7785@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTimvK3p3M8kbGzLxyhchoFONiD4=FGPWxxs=i0GA@mail.gmail.com> <AANLkTimanDRHwoqSj7i9sVCZkze1L3Qp-zFYwTwHAOHX@mail.gmail.com>

On Thu, Jan 13, 2011 at 10:00:45AM -0700, JT Olds wrote:

> I don't have git-sh-setup, which seems like it should be included in
> the git-core package, but it's not. I have git-core
> 1:1.7.1-1.1ubuntu0.1 installed. Obviously this precludes
> get_author_ident_from_commit from working.

Oops, sorry about that. It ships in the /usr/lib/git-core directory
these days (it _used_ to ship in /usr/bin, so "." would find it
automatically). And when I did my test, I was using the git repository
itself, so of course it was in my current directory then. :)

But it looks like you found it.

> Author: jt@instructure.com
> Email: jt@instructure.com
> Subject: removing nondeterminism from test
> Date: Tue, 11 Jan 2011 07:42:30 -0700
> 
> Should "Author" be my name? Could that be what's going on? I don't
> even know where that gets set. The ones that I failed to notice that
> they broke before I pushed them look like this:

Yep, it should be your name. So my next to suspect would be the
git-mailinfo parser, and indeed, that's the thing that has the
3-character limit that Erik mentioned.

So that's definitely the problem.

-Peff

      parent reply	other threads:[~2011-01-13 18:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 16:15 Git Rebase blows away GIT_AUTHOR_NAME JT Olds
2011-01-12 18:21 ` Jeff King
2011-01-13 17:00   ` JT Olds
2011-01-13 17:11     ` JT Olds
2011-01-13 17:47       ` Erik Faye-Lund
2011-01-13 17:52         ` JT Olds
2011-01-13 18:20           ` Erik Faye-Lund
2011-01-14  8:45             ` Tor Arntsen
2011-01-14  8:56               ` Erik Faye-Lund
2011-01-14  9:24                 ` Tor Arntsen
2011-01-14  9:53                   ` Erik Faye-Lund
2011-01-14 14:51                     ` JT Olds
2011-01-14 15:41                     ` Linus Torvalds
2011-01-14 16:13                       ` Erik Faye-Lund
2011-01-14 16:21                         ` Jeff King
2011-01-14 16:30                           ` Erik Faye-Lund
2011-01-14 16:33                             ` Jeff King
2011-01-14 18:02                               ` Jay Soffian
2011-01-14 18:28                           ` Junio C Hamano
2011-01-14 20:07                             ` Jeff King
2011-01-14 22:30                               ` Junio C Hamano
2011-01-17 22:21                           ` Jeff King
2011-01-17 22:29                             ` Erik Faye-Lund
2011-01-18  3:55                             ` JT Olds
2011-01-19  1:33                             ` Jay Soffian
     [not found]                       ` <AANLkTimZF+r2aNzrXsUuHVZR65N5wpOYLutFgGAGoci_@m ail.gmail.com>
2011-01-14 16:21                         ` Tor Arntsen
2011-01-14 16:26                           ` Erik Faye-Lund
2011-01-14 17:18                           ` Linus Torvalds
2011-01-14  9:55                   ` Erik Faye-Lund
2011-01-13 18:47     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110113184739.GA7785@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jtolds@xnet5.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).