From: Clemens Buchacher <drizzd@aon.at>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Alex Riesen" <raa.lkml@gmail.com>
Subject: Re: [RFC/PATCH 0/2] unpack-trees: handle lstat failures in verify_absent
Date: Thu, 13 Jan 2011 21:20:23 +0100 [thread overview]
Message-ID: <20110113202023.GA15912@localhost> (raw)
In-Reply-To: <20110113022415.GA8635@burratino>
On Wed, Jan 12, 2011 at 08:24:15PM -0600, Jonathan Nieder wrote:
>
> Here are two cases where we ignore the result from lstat in
> unpack_trees. I think we rather shouldn't ignore it. Sane?
Looks good. Thanks.
But in addition to the ones you fixed, lstat errors returned by
lstat_cache_matchlen() in check_leading_path() are also ignored.
I was actually hoping to restructure this into two functions.
1) check_path() to see if we need to overwrite anything (leading
directory _or_ file of the same name)
2) check_ok_to_remove() to check if we can safely overwrite that
directory or file
All the lstat handling would go into check_path(), and
check_ok_to_remove() can reuse the stat returned by check_path().
But right now I can't say when I will find the time.
Clemens
next prev parent reply other threads:[~2011-01-13 20:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 20:54 unpack-trees: fix D/F conflict bugs in verify_absent Clemens Buchacher
2009-01-01 20:54 ` [PATCH 1/3] unpack-trees: handle failure " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 2/3] unpack-trees: fix path search bug " Clemens Buchacher
2009-01-01 20:54 ` [PATCH 3/3] unpack-trees: remove redundant path search " Clemens Buchacher
2009-01-06 8:19 ` Junio C Hamano
2009-01-02 21:59 ` [PATCH 2/3] unpack-trees: fix path search bug " Johannes Schindelin
2009-01-03 10:39 ` Clemens Buchacher
2009-01-03 12:53 ` Johannes Schindelin
2009-01-04 10:01 ` Junio C Hamano
2009-01-04 20:01 ` Clemens Buchacher
2009-01-06 19:35 ` Johannes Schindelin
2011-01-13 2:24 ` [RFC/PATCH 0/2] unpack-trees: handle lstat failures " Jonathan Nieder
2011-01-13 2:26 ` [PATCH 1/2] unpack-trees: handle lstat failure for existing directory Jonathan Nieder
2011-01-13 4:37 ` Miles Bader
2011-01-13 5:38 ` Jonathan Nieder
2011-01-13 2:28 ` [PATCH 2/2] unpack-trees: handle lstat failure for existing file Jonathan Nieder
2011-01-13 20:20 ` Clemens Buchacher [this message]
2009-01-01 21:28 ` unpack-trees: fix D/F conflict bugs in verify_absent Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-12-16 23:24 Strange untracked file behaviour Miklos Vajna
2008-12-17 5:09 ` Johannes Schindelin
2008-12-17 14:38 ` Miklos Vajna
2009-01-02 21:59 ` [PATCH 2/3] unpack-trees: fix path search bug in verify_absent Johannes Schindelin
2009-01-03 14:01 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113202023.GA15912@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).