From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: "Joe Corneli" <holtzermann17@gmail.com>,
git@vger.kernel.org, "Love Hörnquist Åstrand" <lha@kth.se>
Subject: Re: working with a large repository and git svn
Date: Fri, 14 Jan 2011 02:29:31 -0600 [thread overview]
Message-ID: <20110114082931.GC11343@burratino> (raw)
In-Reply-To: <20110114080554.GA1735@kytes>
Ramkumar Ramachandra wrote:
> Joe Corneli writes:
>>> I think the state of the art is currently git2svn
>>
>> Thanks, that did indeed work, though, for the record it uses committer
>> name and email in the log that it generates, not author name and
>> email, but no worries!
>
> That should be easy enough to fix with something like this (warning:
> untested). A more elegant solution would actually use some sort of
> user-configurable mapping from Git authors/ committers to SVN authors
> though.
Thanks for the cc. (cc-ing lha, as I should have before.)
I suppose if svn will show only one of the two (committer and author)
then it is better to show the author. Possible complications:
. The author lines in fast-import streams are optional.
. Existing users of the incremental import facility might not want the
meaning of svn:author to change between imports. _If_ that is a
problem then a command-line option to switch behaviors might help.
. Is svn okay with non-monotonic dates? (If not, then the committer
date would need to be used.)
Modulo those complications I like the idea. (Though I haven't read
the implementation, which follows for reference.)
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> --8<--
> diff --git a/git2svn b/git2svn
> index 2380775..3856696 100755
> --- a/git2svn
> +++ b/git2svn
> @@ -261,12 +261,8 @@ COMMAND: while (!eof(IN)) {
> $commit{Mark} = $1;
> $next = next_line($IN);
> }
> - if ($next =~ m/author +(.*)/) {
> - $commit{Author} = $1;
> - $next = next_line($IN);
> - }
> - unless ($next =~ m/committer +(.+) +<([^>]+)> +(\d+) +[+-](\d+)$/) {
> - die "missing comitter: $_";
> + unless ($next =~ m/author +(.+) +<([^>]+)> +(\d+) +[+-](\d+)$/) {
> + die "missing author: $_";
> }
>
> $commit{CommitterName} = $1;
> @@ -275,6 +271,9 @@ COMMAND: while (!eof(IN)) {
> $commit{CommitterTZ} = $4;
>
> $next = next_line($IN);
> + if ($next =~ m/committer +(.*)/) {
> + $next = next_line($IN);
> + }
> my $log = read_data($IN, $next);
>
> $next = next_line($IN);
next prev parent reply other threads:[~2011-01-14 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 1:27 working with a large repository and git svn Joe Corneli
2011-01-12 15:30 ` Wesley J. Landaker
2011-01-13 0:54 ` Joe Corneli
2011-01-13 3:23 ` Jonathan Nieder
2011-01-14 7:43 ` Joe Corneli
2011-01-14 8:05 ` Ramkumar Ramachandra
2011-01-14 8:29 ` Jonathan Nieder [this message]
2011-01-14 9:23 ` Michael Haggerty
[not found] ` <F0299861-B36C-459C-972E-856212A92615@kth.se>
2011-01-14 10:16 ` [PATCH] Optionally parse author information Ramkumar Ramachandra
2011-01-16 2:17 ` Joe Corneli
2011-01-16 2:57 ` Jonathan Nieder
2011-01-16 3:32 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114082931.GC11343@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=holtzermann17@gmail.com \
--cc=lha@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).