From: Jonathan Nieder <jrnieder@gmail.com>
To: Joe Corneli <holtzermann17@gmail.com>
Cc: "Ramkumar Ramachandra" <artagnon@gmail.com>,
"Love Hörnquist Åstrand" <lha@kth.se>,
"Git List" <git@vger.kernel.org>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: Re: [PATCH] Optionally parse author information
Date: Sat, 15 Jan 2011 20:57:07 -0600 [thread overview]
Message-ID: <20110116025707.GB28452@burratino> (raw)
In-Reply-To: <AANLkTi=ddJYT8YiUDYy80xobkxJnvuREN-09=464P_vB@mail.gmail.com>
Joe Corneli wrote:
> I tested it, and it seems to use email handle instead of author name
> (perhaps that's intentional, though in my case it's not so desirable)
Good point. Presumably git2svn is using the local part of the email
address to mimic svn's default behavior of using one's username.
Other possibilities:
- email address (e.g., majordomo@planetmath.org, as in most google
repositories)
- display name (e.g., "Joe Corneli"). I don't know if svn-related
tools or scripts assume that svn:author doesn't contain spaces.
- full ident string (e.g., "Joe Corneli <majordomo@planetmath.org>")
- whatever the operator wants (mapping specified in authors file).
My guess: an "authors file" facility would be needed to cover all
cases, but whichever rule you want to implement short of that could
also be useful.
> but, quite critically, it gets the dates wrong:
>
> ~/pmhistory.svn$ svn log -l 5
> ------------------------------------------------------------------------
> r53127 | majordomo | 2011-01-10 18:31:58 -0500 (Mon, 10 Jan 2011) | 1 line
[...]
> ~/pmhistory.git$ git log -5
> commit 411b8698e494ee12799300611fed0c8029e76ad3
> Author: milogardner <majordomo@planetmath.org>
> Date: Thu Dec 16 14:11:57 2010 +0000
Maybe it is using the committer date (as shown by "git log --format=fuller")
and someone rebased recently. If you don't care about svn's '{date}'
construct working (meaning out-of-order dates are ok) then author date
might be more suitable. Presumably the important thing is for it to
be consistent.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2011-01-16 2:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 1:27 working with a large repository and git svn Joe Corneli
2011-01-12 15:30 ` Wesley J. Landaker
2011-01-13 0:54 ` Joe Corneli
2011-01-13 3:23 ` Jonathan Nieder
2011-01-14 7:43 ` Joe Corneli
2011-01-14 8:05 ` Ramkumar Ramachandra
2011-01-14 8:29 ` Jonathan Nieder
2011-01-14 9:23 ` Michael Haggerty
[not found] ` <F0299861-B36C-459C-972E-856212A92615@kth.se>
2011-01-14 10:16 ` [PATCH] Optionally parse author information Ramkumar Ramachandra
2011-01-16 2:17 ` Joe Corneli
2011-01-16 2:57 ` Jonathan Nieder [this message]
2011-01-16 3:32 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110116025707.GB28452@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=holtzermann17@gmail.com \
--cc=lha@kth.se \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).