From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Drew Northup <drew.northup@maine.edu>, git@vger.kernel.org
Subject: Re: [PATCH] merge: default to @{upstream}
Date: Sun, 30 Jan 2011 15:51:05 -0600 [thread overview]
Message-ID: <20110130215105.GA11332@burratino> (raw)
In-Reply-To: <AANLkTi=iMJv+Jtj8YdYhQ_sxu+jBht5YqvSnkS2LUerz@mail.gmail.com>
Hi again,
Felipe Contreras wrote:
[out of order for convenience]
> Anyway, I don't think we can set argv[1] to NULL, because it's
> possible that this is "char *argv[1]", so that would crash.
The original argc is at least 1 (to include "merge" as argv[0]) before
the args are shifted by parse_options_end. But probably that is too
tricky to rely on.
> Sure, I need to add documentation and tests. I should probably have
> sent this as 'RFC'.
No problem. Thanks for keeping the topic alive.
next prev parent reply other threads:[~2011-01-30 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 16:17 [PATCH] merge: default to @{upstream} Felipe Contreras
2011-01-28 16:44 ` Drew Northup
2011-01-28 17:53 ` Felipe Contreras
2011-01-28 17:56 ` Jonathan Nieder
2011-01-28 18:46 ` Felipe Contreras
2011-01-30 21:51 ` Jonathan Nieder [this message]
2011-01-28 19:53 ` Bert Wesarg
2011-01-28 21:41 ` Martin von Zweigbergk
2011-01-31 1:55 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110130215105.GA11332@burratino \
--to=jrnieder@gmail.com \
--cc=drew.northup@maine.edu \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).