git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yann Dirson <dirson@bertin.fr>
To: git list <git@vger.kernel.org>
Subject: [BUG] "git apply --index" with missing --directory option silently does nothing
Date: Wed, 02 Feb 2011 10:24:45 +0100	[thread overview]
Message-ID: <20110202102445.6ff6c8e4@chalon.bertin.fr> (raw)


When applying a patch file for a subtree of a git repo, where was
required is "git apply --index --directory=...", if the user forgets
to add the --directory flag, then git should bomb out saying it cannot
apply the patch.

But what happens is that nothing happens, and git stays silent about
having done nothing:

~/softs/tmp/linux-2.6.32$ git rev-parse --git-dir
/home/localadm/softs/tmp/.git
~/softs/tmp/linux-2.6.32$ bzcat /home/localadm/Downloads/patch-2.6.32.28.bz2 | git apply --index --whitespace=nowarn
~/softs/tmp/linux-2.6.32$ echo $?
0
~/softs/tmp/linux-2.6.32$ git status
# On branch master
nothing to commit (working directory clean)

-- 
Yann Dirson - Bertin Technologies

                 reply	other threads:[~2011-02-02  9:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202102445.6ff6c8e4@chalon.bertin.fr \
    --to=dirson@bertin.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).