From: Johannes Sixt <j6t@kdbg.org>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: msysgit@googlegroups.com, Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [msysGit] [PATCH 4/4] t5526: avoid dependency on submodule order
Date: Thu, 3 Feb 2011 21:08:54 +0100 [thread overview]
Message-ID: <201102032108.54811.j6t@kdbg.org> (raw)
In-Reply-To: <1296747105-1663-5-git-send-email-patthoyts@users.sourceforge.net>
On Donnerstag, 3. Februar 2011, Pat Thoyts wrote:
> +test_cmp_unordered() {
> + grep --line-regexp -f "$@" >&3
> +}
I don't think that this is sufficiently portable.
Furthermore, just like Dscho, I'd rather prefer to know why the output is not
ordered as expected.
I'm fine with the other patches as well.
A side note regarding SYMLINKS: It's actually possible to remove 70 of the 130
SYMLINKS checks from the test suite:
http://repo.or.cz/w/git/mingw/j6t.git/shortlog/refs/heads/war-on-symlinks
-- Hannes
next prev parent reply other threads:[~2011-02-03 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 15:31 [PATCH] some test fixes for msysGit Pat Thoyts
2011-02-03 15:31 ` [PATCH 1/4] t3509: use unconstrained initial test to setup repository Pat Thoyts
2011-02-03 15:31 ` [PATCH 2/4] t4120-apply-popt: help systems with core.filemode=false Pat Thoyts
2011-02-03 15:31 ` [PATCH 3/4] t7407: fix line endings for mingw build Pat Thoyts
2011-02-03 15:31 ` [PATCH 4/4] t5526: avoid dependency on submodule order Pat Thoyts
2011-02-03 20:08 ` Johannes Sixt [this message]
2011-02-03 20:26 ` [msysGit] " Johannes Schindelin
2011-02-03 20:56 ` Johannes Sixt
2011-02-04 8:41 ` [PATCH maint] start_command: flush buffers in the WIN32 code path as well Johannes Sixt
2011-02-04 11:23 ` Pat Thoyts
2011-02-03 16:29 ` [msysGit] [PATCH] some test fixes for msysGit Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102032108.54811.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).