git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH/RFC 0/7] Column output
Date: Tue, 8 Feb 2011 23:42:10 -0600	[thread overview]
Message-ID: <20110209054210.GA2019@elie> (raw)
In-Reply-To: <AANLkTi=WKnj8M2Uh+ACSay1STgOhWAjQbmspYSja3y0+@mail.gmail.com>

Some general reflections.

Nguyen Thai Ngoc Duy wrote:
> 2011/2/9 Jeff King <peff@peff.net>:

>> I don't really care for column output myself,

Me neither.  I tricked myself into reading with a vague hope that it
might lead to a porcelain-level "git ls" command.

[...]
>> But why not use the BSD column program?
>
> Solaris did not have one last time I checked. Windows obviously does
> not either, but I don't use msysgit so it does not count.

A good reason to port the "column" program, no?  I admit I find this a
compelling excuse not to bother with getting --column options and
core.column configuration right.

All that said.

Patches 1, 2, and 5 replace git help's existing columnation code
with something more reusable and functional.  After those patches,

	git --paginate help -a

no longer forces 80-column output.  Another application of
term_columns could be to teach "git log" and "git log --graph"
to wrap to terminal width some day.

So if I ran the world, I would put those three patches before
--column et al in a possible reroll. :)

Thanks for some clear and pleasant reading.
Jonathan

  reply	other threads:[~2011-02-09  5:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 15:22 [PATCH/RFC 0/7] Column output Nguyễn Thái Ngọc Duy
2011-02-08 15:22 ` [PATCH 1/7] Move term_columns() to pager.c and save terminal width before pager Nguyễn Thái Ngọc Duy
2011-02-09  5:14   ` Jonathan Nieder
2011-02-08 15:22 ` [PATCH 2/7] Add column layout Nguyễn Thái Ngọc Duy
2011-02-09  7:36   ` Jonathan Nieder
2011-02-09 11:24     ` Nguyen Thai Ngoc Duy
2011-02-08 15:22 ` [PATCH 3/7] parseopt: OPT_COLUMN to set struct column_layout.mode Nguyễn Thái Ngọc Duy
2011-02-08 15:22 ` [PATCH 4/7] add core.column Nguyễn Thái Ngọc Duy
2011-02-08 15:22 ` [PATCH 5/7] help: reuse struct column_layout Nguyễn Thái Ngọc Duy
2011-02-09  7:39   ` Jonathan Nieder
2011-02-09 11:21     ` Nguyen Thai Ngoc Duy
2011-02-08 15:22 ` [PATCH 6/7] tag: support column output with --column Nguyễn Thái Ngọc Duy
2011-02-09 21:51   ` Junio C Hamano
2011-02-10  2:35     ` Nguyen Thai Ngoc Duy
2011-02-10  2:54       ` Miles Bader
2011-02-08 15:22 ` [PATCH 7/7] branch: " Nguyễn Thái Ngọc Duy
2011-02-08 22:47 ` [PATCH/RFC 0/7] Column output Jeff King
2011-02-09  0:13   ` Nguyen Thai Ngoc Duy
2011-02-09  5:42     ` Jonathan Nieder [this message]
2011-02-09  5:59       ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209054210.GA2019@elie \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).