From: Jonathan Nieder <jrnieder@gmail.com>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: Jakub Narebski <jnareb@gmail.com>,
Xavier Maillard <zedek@gnu.org>,
Alexandre Julliard <julliard@winehq.org>,
Martin Nordholts <enselic@gmail.com>,
Kevin Ryde <user42@zip.com.au>,
git@vger.kernel.org, Andreas Schwab <schwab@linux-m68k.org>,
Sergei Organov <osv@javad.com>
Subject: Re: git-blame.el: does not show one-line summary in echo area
Date: Thu, 10 Feb 2011 20:29:28 -0600 [thread overview]
Message-ID: <20110211022928.GA24775@elie> (raw)
In-Reply-To: <87oc6sm1ef.fsf@krank.kagedal.org>
David Kågedal wrote:
> I whipped up a patch anyway. This adds an echo area message shown after
> 0.5 seconds of idleness, using the git-blame-echo-format format string.
> Try it and see if makes sense. I can clean it up (and split it up)
> later.
Sorry for the slow response.
Some quick impressions:
- The 0.5 second delay is noticeable but not terrible.
The instantaneous response from the older point-entered based
code was kind of nice --- too bad it has to go.
- There is no obvious way to copy the (abbreviated or full) hash
associated to the current line to the clipboard (for pasting in
another terminal).
People more familiar with emacs might want "git show" output in
another buffer when the line is double-clicked or something. :)
That would work for me, too (since I could copy the hash from
there).
- A nice brief oneline format is
[%h] %a: %s
which goes well with a git-blame-prefix-format of
%t
- The time format (%c) is rather verbose. I think I prefer %D
(so maybe this is a potential tweakable?).
- email addresses are often longer than 20 characters. Does
format-spec provide a way to truncate to a certain length,
so the prefixes can line up?
- in general, I like it. Thanks.
Jonathan
next prev parent reply other threads:[~2011-02-11 2:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 16:21 git-blame.el: what is format-spec? Sergei Organov
2009-12-04 16:38 ` Andreas Schwab
2009-12-04 16:59 ` Sergei Organov
2009-12-04 17:36 ` David Kågedal
2009-12-04 20:54 ` Sergei Organov
2009-12-06 18:43 ` David Kågedal
2009-12-07 8:36 ` Sergei Organov
2009-12-07 9:05 ` David Kågedal
2010-05-14 13:13 ` Alex Unleashed
2010-05-25 13:44 ` [PATCH] git-blame.el: Add (require 'format-spec) David Kågedal
2010-10-29 3:38 ` [PATCH resend] " Jonathan Nieder
2011-02-04 1:43 ` git-blame.el: does not show one-line summary in echo area Jonathan Nieder
2011-02-04 9:53 ` David Kågedal
2011-02-04 10:03 ` Jakub Narebski
2011-02-04 10:15 ` David Kågedal
2011-02-04 12:26 ` David Kågedal
2011-02-11 2:29 ` Jonathan Nieder [this message]
2011-02-11 6:42 ` git-blame.el: format of date strings Jonathan Nieder
2011-02-11 7:56 ` Martin Nordholts
2012-06-10 8:24 ` [PATCH/RFC] git-blame.el: truncate author to avoid jagged left edge of code Jonathan Nieder
2013-01-29 20:17 ` David Kågedal
2011-02-04 21:49 ` git-blame.el: does not show one-line summary in echo area Kevin Ryde
2009-12-04 17:42 ` git-blame.el: what is format-spec? Andreas Schwab
2009-12-04 18:18 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211022928.GA24775@elie \
--to=jrnieder@gmail.com \
--cc=davidk@lysator.liu.se \
--cc=enselic@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=julliard@winehq.org \
--cc=osv@javad.com \
--cc=schwab@linux-m68k.org \
--cc=user42@zip.com.au \
--cc=zedek@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).