From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Barr <david.barr@cordelta.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
vcs-fast-import-devs@lists.launchpad.net
Subject: Re: [PATCH v3] fast-import: add 'ls' command
Date: Fri, 11 Feb 2011 19:36:43 -0600 [thread overview]
Message-ID: <20110212013643.GB24736@elie> (raw)
In-Reply-To: <20110212012153.GA24736@elie>
Jonathan Nieder wrote:
> It is probably be less confusing to use "missing" and let frontends
> handle that rather shielding the frontend from reality. Like so:
^
This should say "rather than", as in: "It is confusing to lie to the
frontend; let's not do that."
Side note: this adds some complication to frontends. For example,
to copy some/path from the commit called :5, without this change,
one could do
echo 'ls :5 some/path'
read -r mode type dataref path
echo "M $mode $dataref $path"
but now one would have to do:
echo 'ls :5 some/path'
read -r mode rest
case $mode in
missing)
echo "D some/path"
;;
*)
dataref=${rest#* }
echo "M $mode $dataref some/path"
;;
esac
The former is simpler; the latter is more explicit and probably less
confusing.
Sorry for the nonsense.
Jonathan
prev parent reply other threads:[~2011-02-12 1:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 22:43 [PATCH v3] fast-import: add 'ls' command Jonathan Nieder
2011-02-11 22:47 ` Sverre Rabbelier
2011-02-11 22:59 ` Jonathan Nieder
2011-02-11 23:51 ` Sverre Rabbelier
2011-02-12 0:40 ` Junio C Hamano
2011-02-12 1:21 ` Jonathan Nieder
2011-02-12 1:36 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212013643.GB24736@elie \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
--cc=vcs-fast-import-devs@lists.launchpad.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).