From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: give more advice when detaching HEAD
Date: Sat, 12 Feb 2011 03:21:08 -0500 [thread overview]
Message-ID: <20110212082108.GA19656@sigill.intra.peff.net> (raw)
In-Reply-To: <7vzkq1y8dv.fsf@alter.siamese.dyndns.org>
On Sat, Feb 12, 2011 at 12:17:16AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Is it that cheap? A full reachability check for something that is not in
> > any ref would involve going to the roots, wouldn't it?
>
> You only need to dig until you hit a merge base, no?
Hmm, yeah, you're right. In the worst case of reachability checks, you
would share no ancestry and go to the roots searching for the merge
base, but of course that is very unlikely to be the case here. So it
should be much cheaper.
> And merge-base has an interface to compute exactly that, I think.
Want to do a proof-of-concept patch? Then we can get some real timings.
-Peff
next prev parent reply other threads:[~2011-02-12 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 7:05 [PATCH] git-gui: give more advice when detaching HEAD Jeff King
2011-02-12 7:42 ` Junio C Hamano
2011-02-12 8:04 ` Jeff King
2011-02-12 8:17 ` Junio C Hamano
2011-02-12 8:21 ` Jeff King [this message]
2011-02-17 23:13 ` Junio C Hamano
2011-02-12 8:42 ` Junio C Hamano
2011-02-13 0:05 ` Sverre Rabbelier
2011-02-13 9:22 ` Johannes Sixt
2011-02-13 23:10 ` Junio C Hamano
2011-02-13 12:31 ` Heiko Voigt
2011-02-15 6:39 ` Jeff King
2011-02-15 19:16 ` Heiko Voigt
2011-02-15 19:48 ` Pat Thoyts
2011-02-16 3:50 ` Jeff King
2011-02-17 17:38 ` Heiko Voigt
2011-02-16 3:46 ` Jeff King
2011-02-17 17:27 ` Heiko Voigt
[not found] ` <5828845.77740.1297797387140.JavaMail.trustmail@mail1.terreactive.ch>
2011-02-16 16:11 ` Victor Engmark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212082108.GA19656@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).